Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateBuildRuntimeConfigurationFiles is not incremental #951

Closed
pranavkm opened this issue Mar 7, 2017 · 1 comment
Closed

GenerateBuildRuntimeConfigurationFiles is not incremental #951

pranavkm opened this issue Mar 7, 2017 · 1 comment

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Mar 7, 2017

Running dotnet build on an application causes it to write runtime config files out to the OutputPath when nothing has changed. Here's the log from an application that was already built:

Target "GenerateBuildRuntimeConfigurationFiles: (TargetId:64)" in file "dotnet\sdk\1.0.0\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.targets" from project "d:\temp\test\test.csproj" (target "_CheckForCompileOutputs" depends on it):
Building target "GenerateBuildRuntimeConfigurationFiles" completely.
Input file "d:\temp\test/runtimeconfig.template.json" does not exist.
Using "GenerateRuntimeConfigurationFiles" task from assembly "dotnet\sdk\1.0.0\Sdks\Microsoft.NET.Sdk\build\..\tools\netcoreapp1.0/Microsoft.NET.Build.Tasks.dll".
Task "GenerateRuntimeConfigurationFiles" (TaskId:23)
 Task Parameter:AssetsFilePath=d:\temp\test\obj\project.assets.json (TaskId:23)
 Task Parameter:TargetFramework=.NETCoreApp,Version=v1.1 (TaskId:23)
 Task Parameter:RuntimeConfigPath=d:\temp\test\bin\Debug\netcoreapp1.1\test.runtimeconfig.json (TaskId:23)
 Task Parameter:RuntimeConfigDevPath=d:\temp\test\bin\Debug\netcoreapp1.1\test.runtimeconfig.dev.json (TaskId:23)
 Task Parameter:PlatformLibraryName=Microsoft.NETCore.App (TaskId:23)
 Task Parameter:UserRuntimeConfig=d:\temp\test/runtimeconfig.template.json (TaskId:23)
Done executing task "GenerateRuntimeConfigurationFiles". (TaskId:23)
Added Item(s): FileWrites=d:\temp\test\bin\Debug\netcoreapp1.1\test.runtimeconfig.json
Added Item(s): FileWrites=d:\temp\test\bin\Debug\netcoreapp1.1\test.runtimeconfig.dev.json

Related:
dotnet run attempts to build the application prior to executing it. https://github.com/dotnet/cli/blob/master/src/dotnet/commands/dotnet-run/RunCommand.cs#L31. Consequently, invoking dotnet run on an already built application concurrently causes it to fail due to file contention produced by GenerateBuildRuntimeConfigurationFiles.

@rainersigwald
Copy link
Member

Duplicate of #496.

(I know this because I filed a duplicate of the same issue yesterday 😇)

mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…r-template

Fix default None items not being removed from Content items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants