Porting changes need for 15.3 VS to work with a 1.0.x SDK to rel/1.0.0 #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changes is the way we discover Sdk references. Now we have support for cross-targeting DT builds for dependencies and can run sdk targetes for each target in DT build. This simplified things since we don't have to call ResolvePackageDependenciesDesignTime to produce flat list accross all targets, but rely on packages evaluated for given target. Project system would know how to map sdk to corresponding package for given target.
…fined in the C#/VB targets in the MsBuild repo)
…gn time targets) and add the InferredFromUsage workaround back.
livarcocc
approved these changes
Apr 21, 2017
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…127.4 (dotnet#1139) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19577.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made a couple of changes to the Project System that are dependent on changes in the SDK. For a newer version of VS to be able to work with the 1.0.x SDK, we need these changes in the 1.0.x SDK. This PR ports:
#949 - Add default configurations.
Without this change, projects fail to load because it won't be able to find any configurations at all.
#1090 - Changes needed for Dependencies tree.
Without this change, the dependencies node will do design-time builds for all target frameworks causing the node to be slower
@abpiskunov can you look to make sure I got this right?
@livarcocc @dsplaisted @nguerrera @dotnet/project-system