Fix for project sstem issue 2069, to specify correct metadata for package for different targets… #1149
Conversation
| @@ -236,7 +236,7 @@ private DependencyType GetDependencyType(string dependencyTypeString) | |||
|
|
|||
| var currentPackageUniqueId = $"{parentTargetId}/{currentItemId}"; | |||
| // add current package to dependencies world | |||
| var currentItem = items[currentItemId]; | |||
There was a problem hiding this comment.
items[currentItemId] [](start = 34, length = 20)
So the objects in items are never added to DependenciesWorld? I guess this is unnecessary extra work in Single-targeting projects(?) -- a (perhaps minor) performance enhancement may be to do this only on cross-targetting projects. #Resolved
There was a problem hiding this comment.
|
/cc @MattGertz for Ask Mode Customer scenario In cross targeting projects, customers may see incorrect nodes in the dependency tree in solution explorer. This is because the task raising dependency hierarchy incorrectly reuses nodes created for the first TFM when processing the hierarchy for subsequent TFMs. The fix is to clone, rather than reuse nodes in multitargeting situations Bugs this fixes: Workarounds, if any N/A Risk Low Performance impact Low. Cloning is applied only in cross-targeting projects where this is the correct thing to do Is this a regression from a previous update? No Root cause analysis: Existing bug exposed by 15.3 work to show all TFMs in solution explorer How was the bug found? Dogfooding |
|
@natidea @abpiskunov is this for master (preview2) or for release/2.0.0 (preview1)? |
|
@abpiskunov can you retarget this to rel/1.0.0? |
…kage for different targets (We reused items for packages accross targets instead of cloning them and it caused all package items for all targets to have dependencyIDs property updated)
srivatsn
force-pushed
the
ap/u3/depenndencyIDs
branch
from
ecdf69d to
6ca35d0
Compare
…0191202.2 (dotnet#1149) - Microsoft.AspNetCore.Analyzers - 5.0.0-alpha1.19602.2 - Microsoft.AspNetCore.Mvc.Api.Analyzers - 5.0.0-alpha1.19602.2 - Microsoft.AspNetCore.Mvc.Analyzers - 5.0.0-alpha1.19602.2 - Microsoft.AspNetCore.Components.Analyzers - 5.0.0-alpha1.19602.2
We reused item object for packages across targets instead of cloning them and it caused all package items for all targets to have dependencyIDs property updated.
Fix for dotnet/project-system#2069