Generate target platform assembly attributes #11499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wli3
changed the title
wli3
force-pushed
the
generate-assmebly-attribute
branch
from
b210484 to
dea5143
Compare
wli3
changed the title
joeloff
reviewed
Jul 8, 2020
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets
Show resolved
Hide resolved
mhutch
approved these changes
Jul 8, 2020
|
Blocked by dotnet/installer#7943 to have the type flowed in |
dsplaisted
approved these changes
Jul 8, 2020
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.GenerateAssemblyInfo.targets
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibraryWithOSMinimumVersion.cs
Show resolved
Hide resolved
wli3
added
auto-merge
|
Hello @wli3! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
wli3
force-pushed
the
generate-assmebly-attribute
branch
from
dea5143 to
3020087
Compare
wli3
commented
Jul 10, 2020
| <ItemGroup Condition="'$(TargetPlatformIdentifier)' != '' | ||
| and '$(MinimumOSPlatform)' != '' | ||
| and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' | ||
| and $([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '5.0'))"> |
There was a problem hiding this comment.
@dsplaisted @mhutch I added the condition on > net5.0 . We won't have the type when it is lower
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11239
make sure
MinimumOSPlatformis the property name we want derive the property directly from.MinimumOSPlatformwill default toTargetPlatformVersionis fine.$(TargetPlatformIdentifier)$(MinimumOSPlatform)--- "Windows10.0.1234"