Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support runtimecopylocal to enable cswinrt #12232

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

wli3
Copy link

@wli3 wli3 commented Jun 26, 2020

fix #11556

Pending NuGet/NuGet.Client#3479 . Currently use a temp implementation.
Pending #12202 , so we can remove explicit definition in for TargetPlatformIdentifier and TargetPlatformVersion
Pending an edit in KnownFrameworkReference, when Microsoft.Windows.SDK.NET.Ref is ready

test project (Cannot make an automated test now since the windows package is not pushed to a feed):

<Project Sdk="Microsoft.NET.Sdk">

	<ItemGroup>
    	<KnownFrameworkReference Include="Microsoft.Windows.SDK.NET.Ref"
                              TargetFramework="net5.0-windows10.0.18362"
                              RuntimeFrameworkName="Microsoft.Windows.SDK.NET.Ref"
                              DefaultRuntimeFrameworkVersion="10.0.18362.1-preview"
                              LatestRuntimeFrameworkVersion="10.0.18362.1-preview"
                              TargetingPackName="Microsoft.Windows.SDK.NET.Ref"
                              TargetingPackVersion="10.0.18362.1-preview"
                              RuntimePackNamePatterns="Microsoft.Windows.SDK.NET.Ref"
							  RuntimePackRuntimeIdentifiers="any"
							  RuntimeCopylocal="true"
							  IsWindowsOnly="true"
                              />
	</ItemGroup>

	<PropertyGroup>
		<OutputType>Exe</OutputType>
		<TargetFramework>net5.0</TargetFramework>
		<TargetPlatformIdentifier>Windows</TargetPlatformIdentifier>
		<TargetPlatformVersion>10.0.18362</TargetPlatformVersion>
	</PropertyGroup>

</Project>


public KnownRuntimePack ToKnownRuntimePack()
{
return new KnownRuntimePack(_item);
}
}

// TODO replace with the proper impl from nuget
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuget change is still not ready. I will check it in for now.

@wli3 wli3 requested a review from dsplaisted June 29, 2020 05:18
A new flag for knownframework. I will copy the dlls to the output folder
and it will not write the framework into runtimeconfig.json
@wli3 wli3 force-pushed the dev/wul/support-cswinrt5 branch from c0b1c0d to 17701af Compare July 1, 2020 05:33
@wli3 wli3 added auto-merge Automatically merge PR once CI passes. Auto-Merge If Tests Pass labels Jul 1, 2020
@ghost
Copy link

ghost commented Jul 1, 2020

Hello @wli3!

Because this pull request has the Auto-Merge If Tests Pass label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 1, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Merge If Tests Pass auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide WinRT APIs for projects targeting Windows
2 participants