Deploy copy-local package satellites correctly #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
force-pushed
the
fix-1006
branch
2 times, most recently
from
a23d06f to
74a54b2
Compare
livarcocc
approved these changes
May 18, 2017
AArnott
reviewed
May 18, 2017
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net46</TargetFramework> |
There was a problem hiding this comment.
I'll add the coverage.
The diff shown in #1132 also changes from netstandard1.4 to net46. Are you sure that you had <TargetFramework>net46</TargetsFramework> working and only <TargetFrameworks>net46[;...]</TargetFrameworks> failing? This very test repros the issue without using TargetFrameworks.
There was a problem hiding this comment.
Good question. I don't remember whether I noticed and checked the one case without conflating the other.
There was a problem hiding this comment.
I've added the coverage in 7ba7a66 to be safe. I can't see from code inspection how TargetFramework vs TargetFrameworks would make any difference so I suspect things were conflated.
|
@MattGertz for approval |
mmitche
pushed a commit
to mmitche/sdk
that referenced
this pull request
Jun 5, 2020
…117.2 (dotnet#1224) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20067.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Targeting desktop and consuming any package containing satellite assemblies. The satellite assemblies were not deployed to the correct location (on build, publish was OK) and so they simply do not load as expected.
Bugs this fixes
#1006
Workarounds, if any
None.
Risk
Low. The change is scoped to the case that is failing.
Performance impact
Minimal. Some additional path computation is done, but only in the case that is currently broken.
Root cause analysis
Lack of test coverage for intersection of desktop-targeting and packages with satellite assemblies. Test gap is closed along with the change.
How was the bug found?
Customer reported and identified as blocking on several email threads with customers and partners.
@dsplaisted @dotnet/dotnet-cli