Reenable graph tests without isolation #13171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdmihai are you still actively working on this? |
|
Nope, it kind of fell through the cracks and I forgot about it. From what I've looked, it does not appear to be anything from the graph part that's freezing it. I'll put it on my backlog and hopefully get to it at some point. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13077 disables both graph and isolation tests. This PR reenables graph tests, leaving isolation out until we fix the issue.
Non isolation graph tests catch regressions which most likely break Cloudbuild (graph shape is incorrect).
Isolation graph tests catch potential behaviour deviations between graph based and vanilla builds. There is a nonexistent to low chance any one of these would break Cloudbuild, but the chance of breakage rises if many deviations accumulate. Ideally we should keep them at zero.
I also extracted the tests to their own class, to make the requirement more explicit and to make it easier to enhance the tests in the future.