Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix F# project loading #1372

Closed

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Jun 27, 2017

fix dotnet/fsharp#3263 (project loading)
fix dotnet/fsharp#3262 (debugging)

to test it locally, change C:\Program Files\dotnet\sdk\2.0.0-preview2-006502\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.Sdk.FSharp.targets to apply the PR changes

before:

image

after:

image

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2017

@brettfo @KevinRansom @srivatsn @livarcocc didn't we already merge a change like this? Is it just that it is in a release branch and not master?

@enricosada
Copy link
Contributor Author

after this also debuggin works, no intellisense

@enricosada
Copy link
Contributor Author

@Pilchie seems was fixed in a branch, but is not in 15.3 preview3, dotnet/fsharp#3263 (comment)

Closing

@enricosada enricosada closed this Jun 27, 2017
mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
* Update dependencies from https://github.com/dotnet/aspnetcore build 20200328.11

- Microsoft.AspNetCore.Analyzers - 5.0.0-preview.3.20178.11
- Microsoft.AspNetCore.Components.Analyzers - 5.0.0-preview.3.20178.11
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 5.0.0-preview.3.20178.11
- Microsoft.AspNetCore.Mvc.Analyzers - 5.0.0-preview.3.20178.11

* Update dependencies from https://github.com/dotnet/aspnetcore build 20200329.3

- Microsoft.AspNetCore.Analyzers - 5.0.0-preview.3.20179.3
- Microsoft.AspNetCore.Components.Analyzers - 5.0.0-preview.3.20179.3
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 5.0.0-preview.3.20179.3
- Microsoft.AspNetCore.Mvc.Analyzers - 5.0.0-preview.3.20179.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants