Adds fallback folder for full framework projects. #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you need to target the 1.1 branch? |
|
@srivatsn No, we only have this for 2.0 CLI. For 1.0 packages, VS still carries its own offline feed. |
livarcocc
force-pushed
the
improve_fallback_folder
branch
from
25dd9c4 to
77f0332
Compare
nguerrera
reviewed
Jul 25, 2017
| // https://github.com/NuGet/Home/issues/5596 and https://github.com/dotnet/project-system/issues/2605 | ||
| //[InlineData("netcoreapp2.0;net461", "multiTFM20app", false)] | ||
| //[InlineData("netcoreapp1.0;netcoreapp2.0", "multiTFM1020app", true)] | ||
| //[InlineData("netcoreapp1.0;net461", "multiTFM1046app", true)] |
There was a problem hiding this comment.
These can be enabled now, right?
nguerrera
approved these changes
Jul 25, 2017
Setting RestoreAdditionalProjectFallbackFoldersExcludes when the TFM is 1.x to prevent fallback folders from being used in that case. Note that NuGet will have to do the aggregation of these properties in order for this to work.
|
@MattGertz for approval. The corresponding nuget change was approved. |
…t version that we need.
livarcocc
force-pushed
the
improve_fallback_folder
branch
from
77f0332 to
ac3c196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Fallback folders were not being set for full framework projects nor multi-tfm projects. Adds fallback folder for full framework projects by removing the condition on the project being netstandard or netcore. Also, sets RestoreAdditionalProjectFallbackFoldersExcludes that NuGet needs to aggregate over in order to remove fallback folders whenever a 1.x project is used.
Bugs this fixes:
Fixes #1389
Workarounds, if any
Don't use the offline cache. Instead, we will hit the web during restore for Multi-tfm projects.
Risk
Low
Performance impact
None.
Is this a regression from a previous update?
Yes.
Root cause analysis:
We were only setting the property for NuGet in the inner-loop.
How was the bug found?
Partner team.
@dotnet/dotnet-cli for review
@srivatsn for approval