[Workaround] Fallback folder workaround for multi tfm #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting RestoreAdditionalProjectFallbackFoldersExcludes when the TFM is 1.x to prevent fallback folders from being used in that case. Note that NuGet will have to do the aggregation of these properties in order for this to work.
…or multi-tfm projects. The change is to run a contains from TargetFrameworks.
|
I validated these changes in VS and it was picking up the fallback folder and source appropriately. |
|
We don't need the workaround as the real fix in nuget got approved. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
Fallback folders were not being set for full framework projects nor multi-tfm projects. Adds fallback folder for full framework projects by removing the condition on the project being netstandard or netcore. Also, as a workaround for a fix we need from NuGet, use the TargetFrameworks to set the NuGet configuration, thus enabling fallback folders for multi-tfm projects.
Bugs this fixes:
Fixes #1389
Workarounds, if any
Don't use the offline cache. Instead, we will hit the web during restore for Multi-tfm projects.
Risk
Low
Performance impact
None.
Is this a regression from a previous update?
Yes.
Root cause analysis:
We were only setting the property for NuGet in the inner-loop.
How was the bug found?
Partner team.
@dotnet/dotnet-cli for review
@srivatsn for approval