Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert NuGet Build 4.4.0-preview1-4434 into sdk #1528

Merged
merged 3 commits into from
Aug 25, 2017

Conversation

nugetlurker
Copy link
Collaborator

Insert NuGet Build 4.4.0-preview1-4434 into sdk release/2.0-vs branch

@jainaashish
Copy link

CC @dsplaisted @nguerrera @livarcocc

@rohit21agrawal
Copy link
Contributor

@dotnet-bot test Ubuntu16.04 Release please

@rohit21agrawal
Copy link
Contributor

@dotnet-bot test
Windows_NT Debug please

@wli3
Copy link

wli3 commented Aug 24, 2017

@rohit21agrawal our test are looking for nspec, and it is moved, I am fixing the test

@rohit21agrawal
Copy link
Contributor

@wli3 i already fixed the tests

@wli3
Copy link

wli3 commented Aug 24, 2017

@rohit21agrawal ah, great

@wli3
Copy link

wli3 commented Aug 24, 2017

@rohit21agrawal looks good. But due to the circular dependency we need to wait for the build of dotnet/cli#7499 and insert it into SDK along with nuget version update

@rohit21agrawal
Copy link
Contributor

i dont think we need to update it every single time.. only when there are breaking api changes in NuGet... is that correct @nguerrera ?

@nguerrera
Copy link
Contributor

Talked offline, we're just going to do it to ensure there are no version mismatches. Sometimes they don't cause issues, but we still need the copies of nuget dlls in the SDK to match the CLI when we ship. Doing it every time makes sure we don't get it wrong. Counting the days until there's just one repo for both and this just goes away. :)

@wli3
Copy link

wli3 commented Aug 25, 2017

@nguerrera @dsplaisted @johnbeisner FYI i update DotnetCLIVersion to a version that has the new nuget but failed to upload to nuget feed

@wli3
Copy link

wli3 commented Aug 25, 2017

@MattGertz FYI this is discussed nuget version flow to SDK

@wli3 wli3 merged commit 7ef4b4b into release/2.0-vs Aug 25, 2017
@nguerrera nguerrera deleted the nuget-insertbuild4434 branch August 25, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants