-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert NuGet Build 4.4.0-preview1-4434 into sdk #1528
Conversation
@dotnet-bot test Ubuntu16.04 Release please |
@dotnet-bot test |
@rohit21agrawal our test are looking for nspec, and it is moved, I am fixing the test |
@wli3 i already fixed the tests |
@rohit21agrawal ah, great |
@rohit21agrawal looks good. But due to the circular dependency we need to wait for the build of dotnet/cli#7499 and insert it into SDK along with nuget version update |
i dont think we need to update it every single time.. only when there are breaking api changes in NuGet... is that correct @nguerrera ? |
Talked offline, we're just going to do it to ensure there are no version mismatches. Sometimes they don't cause issues, but we still need the copies of nuget dlls in the SDK to match the CLI when we ship. Doing it every time makes sure we don't get it wrong. Counting the days until there's just one repo for both and this just goes away. :) |
@nguerrera @dsplaisted @johnbeisner FYI i update DotnetCLIVersion to a version that has the new nuget but failed to upload to nuget feed |
@MattGertz FYI this is discussed nuget version flow to SDK |
Insert NuGet Build 4.4.0-preview1-4434 into sdk release/2.0-vs branch