Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert self-contained implicit versions to 1.0.5/1.1.2/2.0.0 #1574

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Revert self-contained implicit versions to 1.0.5/1.1.2/2.0.0 #1574

merged 1 commit into from
Sep 11, 2017

Conversation

nguerrera
Copy link
Contributor

NOTE: This just bumps the versions back down with reverting the whole commit because

  1. We need a fix in that commit to actually use 2.0.0 instead of the bundled version for framework-dependent apps
  2. There's test cleanup that allows these versions to be changed and test to pass that we should keep.

dsplaisted
dsplaisted approved these changes Sep 9, 2017
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a similar change in the rel/1.1.0 branch

@livarcocc
Copy link
Contributor

@MattGertz can you approve this please?

@livarcocc livarcocc added this to the 2.0.0 milestone Sep 9, 2017
@nguerrera nguerrera merged commit 96f80f1 into dotnet:release/2.0.0 Sep 11, 2017
@nguerrera
Copy link
Contributor Author

@livarcocc @dsplaisted This needs to be inserted in to 2.0.x CLI

@dsplaisted dsplaisted mentioned this pull request Sep 12, 2017
Merged
@nguerrera nguerrera deleted the rollback-2.0 branch September 12, 2017 01:40
@dsplaisted dsplaisted mentioned this pull request Sep 25, 2017
Merged
@dsplaisted dsplaisted mentioned this pull request Mar 23, 2018
Merged
@mmalolepszy mmalolepszy mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@livarcocc livarcocc Awaiting requested review from livarcocc

Assignees
No one assigned
Labels
Approved to merge
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nguerrera @livarcocc @dsplaisted @dnfclas @MattGertz