Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow runtime packs to not be downloaded #15944

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Allow runtime packs to not be downloaded #15944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public class ProcessFrameworkReferences : TaskBase

public bool EnableTargetingPackDownload { get; set; }

public bool EnableRuntimePackDownload { get; set; }

public ITaskItem[] FrameworkReferences { get; set; } = Array.Empty<ITaskItem>();

public ITaskItem[] KnownFrameworkReferences { get; set; } = Array.Empty<ITaskItem>();
Expand Down Expand Up @@ -286,7 +288,7 @@ var runtimeRequiredByDeployment
}

ProcessRuntimeIdentifier(hasRuntimePackAlwaysCopyLocal ? "any" : RuntimeIdentifier, runtimePackForRuntimeIDProcessing, runtimePackVersion, additionalFrameworkReferencesForRuntimePack,
unrecognizedRuntimeIdentifiers, unavailableRuntimePacks, runtimePacks, packagesToDownload, isTrimmable, includeInPackageDownload);
unrecognizedRuntimeIdentifiers, unavailableRuntimePacks, runtimePacks, packagesToDownload, isTrimmable, EnableRuntimePackDownload && includeInPackageDownload);

processedPrimaryRuntimeIdentifier = true;
}
Expand Down
6 changes: 4 additions & 2 deletions .../Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ Copyright (c) .NET Foundation. All rights reserved.
<FrameworkReference Include="@(_FrameworkReferenceToAdd)" />
</ItemGroup>

<PropertyGroup Condition="'$(EnableTargetingPackDownload)' == ''">
<EnableTargetingPackDownload>true</EnableTargetingPackDownload>
<PropertyGroup>
<EnableTargetingPackDownload Condition="'$(EnableTargetingPackDownload)' == ''">true</EnableTargetingPackDownload>
<EnableRuntimePackDownload Condition="'$(EnableRuntimePackDownload)' == ''">true</EnableRuntimePackDownload>
</PropertyGroup>

<PropertyGroup>
Expand Down Expand Up @@ -78,6 +79,7 @@ Copyright (c) .NET Foundation. All rights reserved.
TargetLatestRuntimePatch="$(TargetLatestRuntimePatch)"
TargetLatestRuntimePatchIsDefault="$(_TargetLatestRuntimePatchIsDefault)"
EnableTargetingPackDownload="$(EnableTargetingPackDownload)"
EnableRuntimePackDownload="$(EnableRuntimePackDownload)"
KnownCrossgen2Packs="@(KnownCrossgen2Pack)"
NETCoreSdkRuntimeIdentifier="$(NETCoreSdkRuntimeIdentifier)">

Expand Down