Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only infer winexe output type on net5.0 and greater #16472

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

sfoslund
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@sfoslund sfoslund requested a review from dsplaisted March 22, 2021 20:42
@sfoslund
Copy link
Member Author

Oops I sent this to main. @dsplaisted do we want it in 5.0.3xx?

@dsplaisted
Copy link
Member

Good catch. Yes, this should go in 5.0.3xx.

@sfoslund sfoslund changed the base branch from main to release/5.0.3xx March 22, 2021 21:02
@sfoslund sfoslund merged commit ef6df48 into dotnet:release/5.0.3xx Mar 23, 2021
@sfoslund sfoslund deleted the WinExe branch March 23, 2021 17:44
@jogibear9988
Copy link

@sfoslund @marcpopMSFT
have you read all the complains? for example also the one in my ticket? dotnet/wpf#4314
Also if it is not the default any more, how could the user switch to console via the visual studio UI? what is the user experience if he changes a dropdown, and after that the value jumps back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants