Add support for analyzers from ref-packs #18501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Also add analyzers to conflict resolution.
ericstj
force-pushed
the
frameworkAnalyzers
branch
from
61c03d2 to
70077b9
Compare
This was referenced Jun 24, 2021
|
@dsplaisted @wli3 can one of you have a look at this and give some guidance around what might be missing? I did what I think might be the minimum to enable the scenario but I expect to need to do more :) |
dsplaisted
approved these changes
Jun 25, 2021
src/Tasks/Microsoft.NET.Build.Tasks/ResolveTargetingPackAssets.cs
Outdated
Show resolved
Hide resolved
|
Did you have a suggestion for where to look for such tests, @dsplaisted? I saw tests of the conflict resolver itself, but nothing that tested the task level where this logic lives. I might be missing something though. |
|
I added a test that forced inbox and OOB SDK analyzers to be used. I made it fail locally by disabling the conflict-resolution change in targets: Then put my change back in place and it succeeds. I think this is ready to go. |
dsplaisted
approved these changes
Jun 25, 2021
ViktorHofer
reviewed
Jun 28, 2021
...sks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jun 28, 2021
|
Tested this with the work I have in PR in arcade/runtime and it's working as expected. Thanks folks! |
v-wuzhai
pushed a commit
that referenced
this pull request
Apr 22, 2024
… log (#18501) Noticed in dotnet/installer#18409 that errors aren't propagated which resulted in builds not to fail. The fix here is to use `OnError` in the correct target (but only when using the minimal console log feature) and not set `IgnoreStandardErrorWarningFormat=true` on the Exec task that invokes the repo build script. I also cleaned targets up as those introduced unnecessary complexity and logged in cases when they shouldn't (i.e. in dotnet.proj or package-source-build.proj). This affected runtime which errors after 30s of building because of RuntimeOS and BaseOS being passed in in-correctly. Regressed with dotnet/installer@a265140#diff-86602308e6bb519266bc2f224ea65e39589d273804d40ad0f9c6e0eea2a263dc. Fixed that in runtime.proj. Kudos to Alexander who made the fix. I just copied it in form his CI PR.
ViktorHofer
added a commit
that referenced
this pull request
May 7, 2024
… log (#18501) Noticed in dotnet/installer#18409 that errors aren't propagated which resulted in builds not to fail. The fix here is to use `OnError` in the correct target (but only when using the minimal console log feature) and not set `IgnoreStandardErrorWarningFormat=true` on the Exec task that invokes the repo build script. I also cleaned targets up as those introduced unnecessary complexity and logged in cases when they shouldn't (i.e. in dotnet.proj or package-source-build.proj). This affected runtime which errors after 30s of building because of RuntimeOS and BaseOS being passed in in-correctly. Regressed with dotnet/installer@37ddec7#diff-86602308e6bb519266bc2f224ea65e39589d273804d40ad0f9c6e0eea2a263dc. Fixed that in runtime.proj. Kudos to Alexander who made the fix. I just copied it in form his CI PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add analyzers to conflict resolution.
Implements https://github.com/dotnet/designs/blob/main/accepted/2021/InboxSourceGenerators.md