Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add support for an F# crosstargeting specific targets file #1874

Closed
wants to merge 1 commit into from

Conversation

KevinRansom
Copy link
Member

dotnet pack happens in the crosstargeting phase of sdk build. This extensibility point allows F# to customize pack for F# specific builds.

@KevinRansom
Copy link
Member Author

@dotnet-bot test this please

@wli3
Copy link

wli3 commented Jan 19, 2018

@dotnet-bot test Windows_NT Debug

@mmitche
Copy link
Member

mmitche commented Jan 19, 2018

@dotnet-bot test this please

@KevinRansom
Copy link
Member Author

@nguerrera I'm not certain I really need this, so I will pull it only when I am certain.

Thanks for the review.

Kevin

@nguerrera nguerrera changed the title Add support for an F# crosstargeting specific targets file WIP Add support for an F# crosstargeting specific targets file Jan 20, 2018
@nguerrera
Copy link
Contributor

nguerrera commented Jan 20, 2018

Ok, marking it WIP to prevent someone else from merging

@nguerrera
Copy link
Contributor

Closing since there hasn't been any sign that this is needed. Reopen and remove WIP if you end up actually needing it.

@nguerrera nguerrera closed this Feb 16, 2018
@KevinRansom KevinRansom deleted the fsharppack branch September 18, 2018 04:55
GangWang01 pushed a commit to GangWang01/sdk that referenced this pull request Jun 7, 2022
* Join macro

* Make default format for the GUID macro overridable

Fixes dotnet#1737

* Add links to the different template content repos in the readme

* Convert repo list to bullets

* Adding netstandard2.1 to the list of TFMs for 3.0

* Releases the original source location mount point

* Change Build pool for internal builds (dotnet#1823)

* Removing the SourceLink packages since it is provided by Arcade

* Lowercase the content include path in the template pack csproj files

* Add gitignore template

* Update azure-pipelines.yml

* Update web.config item template

This updates the web.config item template to align with what `dotnet publish` produces when publishing

* Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config

Co-Authored-By: Justin Kotalik <jukotali@microsoft.com>

* Merge master into stabilize (dotnet#1905)

* Update dependencies from https://github.com/dotnet/arcade build 20190418.7 (dotnet#1867)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.7

* Update dependencies from https://github.com/dotnet/arcade build 20190422.2 (dotnet#1870)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19222.2

* Update dependencies from https://github.com/dotnet/arcade build 20190423.2 (dotnet#1871)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19223.2

* Update dependencies from https://github.com/dotnet/arcade build 20190424.9 (dotnet#1873)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19224.9

* Update dependencies from https://github.com/dotnet/arcade build 20190425.5 (dotnet#1874)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19225.5

* Update dependencies from https://github.com/dotnet/arcade build 20190426.3 (dotnet#1875)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19226.3

* Update dependencies from https://github.com/dotnet/arcade build 20190429.8 (dotnet#1876)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19229.8

* Update dependencies from https://github.com/dotnet/arcade build 20190430.6 (dotnet#1877)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6

* [master] Update dependencies from dotnet/arcade (dotnet#1879)

* Update dependencies from https://github.com/dotnet/arcade build 20190501.6

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19251.6

* Update dependencies from https://github.com/dotnet/arcade build 20190502.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19252.2

* Update dependencies from https://github.com/dotnet/arcade build 20190503.8 (dotnet#1881)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8

* Update dependencies from https://github.com/dotnet/arcade build 20190504.1 (dotnet#1882)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1

* Update dependencies from https://github.com/dotnet/arcade build 20190505.2 (dotnet#1883)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2

* Update dependencies from https://github.com/dotnet/arcade build 20190506.12 (dotnet#1886)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12

* [master] Update dependencies from dotnet/arcade (dotnet#1888)

* Update dependencies from https://github.com/dotnet/arcade build 20190507.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7

* Update dependencies from https://github.com/dotnet/arcade build 20190508.5

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5

* Update dependencies from https://github.com/dotnet/arcade build 20190509.9 (dotnet#1889)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9

* Update dependencies from https://github.com/dotnet/arcade build 20190510.2 (dotnet#1890)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19260.2

* Update dependencies from https://github.com/dotnet/arcade build 20190511.1 (dotnet#1891)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19261.1

* Update dependencies from https://github.com/dotnet/arcade build 20190512.1 (dotnet#1892)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19262.1

* Update dependencies from https://github.com/dotnet/arcade build 20190513.3 (dotnet#1893)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3

* [master] Update dependencies from dotnet/arcade (dotnet#1895)

* Update dependencies from https://github.com/dotnet/arcade build 20190514.13

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19264.13

* Update dependencies from https://github.com/dotnet/arcade build 20190516.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.2

* Update dependencies from https://github.com/dotnet/arcade build 20190516.4

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.4

* Update dependencies from https://github.com/dotnet/arcade build 20190517.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19267.7

* Update dependencies from https://github.com/dotnet/arcade build 20190518.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19268.2

* Update dependencies from https://github.com/dotnet/arcade build 20190520.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1

* Update dependencies from https://github.com/dotnet/arcade build 20190520.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.2

* Updating the glob.json to include the 2.1.x version

* Update dependencies from https://github.com/dotnet/arcade build 20190521.7 (dotnet#1897)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19271.7

* Update dependencies from https://github.com/dotnet/arcade build 20190522.13 (dotnet#1898)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13

* Update dependencies from https://github.com/dotnet/arcade build 20190523.11 (dotnet#1899)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19273.11

* Update dependencies from https://github.com/dotnet/arcade build 20190524.6 (dotnet#1901)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19274.6

* Update dependencies from https://github.com/dotnet/arcade build 20190528.1 (dotnet#1903)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19278.1

* Merging stabilize into master (dotnet#1904)

* Join macro

* Make default format for the GUID macro overridable

Fixes dotnet#1737

* Add links to the different template content repos in the readme

* Convert repo list to bullets

* Adding netstandard2.1 to the list of TFMs for 3.0

* Releases the original source location mount point

* Change Build pool for internal builds (dotnet#1823)

* Removing the SourceLink packages since it is provided by Arcade

* Lowercase the content include path in the template pack csproj files

* Add gitignore template

* Update azure-pipelines.yml

* Update web.config item template

This updates the web.config item template to align with what `dotnet publish` produces when publishing

* Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config

Co-Authored-By: Justin Kotalik <jukotali@microsoft.com>

* Update --langVersion option's description

* Removing Microsoft.Extensions.CommandLineUtils references from the repo
GangWang01 pushed a commit to GangWang01/sdk that referenced this pull request Jul 11, 2022
* Join macro

* Make default format for the GUID macro overridable

Fixes dotnet#1737

* Add links to the different template content repos in the readme

* Convert repo list to bullets

* Adding netstandard2.1 to the list of TFMs for 3.0

* Releases the original source location mount point

* Change Build pool for internal builds (dotnet#1823)

* Removing the SourceLink packages since it is provided by Arcade

* Lowercase the content include path in the template pack csproj files

* Add gitignore template

* Update azure-pipelines.yml

* Update web.config item template

This updates the web.config item template to align with what `dotnet publish` produces when publishing

* Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config

Co-Authored-By: Justin Kotalik <jukotali@microsoft.com>

* Merge master into stabilize (dotnet#1905)

* Update dependencies from https://github.com/dotnet/arcade build 20190418.7 (dotnet#1867)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.7

* Update dependencies from https://github.com/dotnet/arcade build 20190422.2 (dotnet#1870)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19222.2

* Update dependencies from https://github.com/dotnet/arcade build 20190423.2 (dotnet#1871)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19223.2

* Update dependencies from https://github.com/dotnet/arcade build 20190424.9 (dotnet#1873)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19224.9

* Update dependencies from https://github.com/dotnet/arcade build 20190425.5 (dotnet#1874)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19225.5

* Update dependencies from https://github.com/dotnet/arcade build 20190426.3 (dotnet#1875)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19226.3

* Update dependencies from https://github.com/dotnet/arcade build 20190429.8 (dotnet#1876)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19229.8

* Update dependencies from https://github.com/dotnet/arcade build 20190430.6 (dotnet#1877)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6

* [master] Update dependencies from dotnet/arcade (dotnet#1879)

* Update dependencies from https://github.com/dotnet/arcade build 20190501.6

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19251.6

* Update dependencies from https://github.com/dotnet/arcade build 20190502.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19252.2

* Update dependencies from https://github.com/dotnet/arcade build 20190503.8 (dotnet#1881)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8

* Update dependencies from https://github.com/dotnet/arcade build 20190504.1 (dotnet#1882)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1

* Update dependencies from https://github.com/dotnet/arcade build 20190505.2 (dotnet#1883)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2

* Update dependencies from https://github.com/dotnet/arcade build 20190506.12 (dotnet#1886)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12

* [master] Update dependencies from dotnet/arcade (dotnet#1888)

* Update dependencies from https://github.com/dotnet/arcade build 20190507.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7

* Update dependencies from https://github.com/dotnet/arcade build 20190508.5

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5

* Update dependencies from https://github.com/dotnet/arcade build 20190509.9 (dotnet#1889)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9

* Update dependencies from https://github.com/dotnet/arcade build 20190510.2 (dotnet#1890)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19260.2

* Update dependencies from https://github.com/dotnet/arcade build 20190511.1 (dotnet#1891)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19261.1

* Update dependencies from https://github.com/dotnet/arcade build 20190512.1 (dotnet#1892)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19262.1

* Update dependencies from https://github.com/dotnet/arcade build 20190513.3 (dotnet#1893)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19263.3

* [master] Update dependencies from dotnet/arcade (dotnet#1895)

* Update dependencies from https://github.com/dotnet/arcade build 20190514.13

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19264.13

* Update dependencies from https://github.com/dotnet/arcade build 20190516.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.2

* Update dependencies from https://github.com/dotnet/arcade build 20190516.4

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19266.4

* Update dependencies from https://github.com/dotnet/arcade build 20190517.7

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19267.7

* Update dependencies from https://github.com/dotnet/arcade build 20190518.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19268.2

* Update dependencies from https://github.com/dotnet/arcade build 20190520.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.1

* Update dependencies from https://github.com/dotnet/arcade build 20190520.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19270.2

* Updating the glob.json to include the 2.1.x version

* Update dependencies from https://github.com/dotnet/arcade build 20190521.7 (dotnet#1897)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19271.7

* Update dependencies from https://github.com/dotnet/arcade build 20190522.13 (dotnet#1898)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13

* Update dependencies from https://github.com/dotnet/arcade build 20190523.11 (dotnet#1899)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19273.11

* Update dependencies from https://github.com/dotnet/arcade build 20190524.6 (dotnet#1901)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19274.6

* Update dependencies from https://github.com/dotnet/arcade build 20190528.1 (dotnet#1903)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19278.1

* Merging stabilize into master (dotnet#1904)

* Join macro

* Make default format for the GUID macro overridable

Fixes dotnet#1737

* Add links to the different template content repos in the readme

* Convert repo list to bullets

* Adding netstandard2.1 to the list of TFMs for 3.0

* Releases the original source location mount point

* Change Build pool for internal builds (dotnet#1823)

* Removing the SourceLink packages since it is provided by Arcade

* Lowercase the content include path in the template pack csproj files

* Add gitignore template

* Update azure-pipelines.yml

* Update web.config item template

This updates the web.config item template to align with what `dotnet publish` produces when publishing

* Update template_feed/Microsoft.DotNet.Common.ItemTemplates/content/WebConfig/web.config

Co-Authored-By: Justin Kotalik <jukotali@microsoft.com>

* Update --langVersion option's description

* Removing Microsoft.Extensions.CommandLineUtils references from the repo
JL03-Yue pushed a commit that referenced this pull request Mar 19, 2024
Revert "System.CommandLine update"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants