-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Don't set a default ProjectAssetsFile path in the SDK #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set a default ProjectAssetsFile path in the SDK #2010
Conversation
dc5b1e5
to
4bb702d
Compare
@dotnet-bot test OSX10.12 Debug |
<trans-unit id="AssetsFileNotSet"> | ||
<source>ProjectAssetsFile was not set. Run a NuGet package restore to generate this file.</source> | ||
<target state="new">ProjectAssetsFile was not set. Run a NuGet package restore to generate this file.</target> | ||
<note>"ProjectAssetsFile" is the name of a property and parameter to the task, so it should not be translated</note> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a common enough case, right? e.g. You'd get it using msbuild
without /restore with no prior restore?. I don't think we should be mentioning ProjectAssetsFile the variable, but rather the fact that we can't locate the project assets file. This is getting into the implementation details.
I've updated the message per @nguerrera's suggestion. However, we may want to wait until NuGet/NuGet.Client#2056 is ready to merge before making this change. Otherwise, projects which set |
@dsplaisted, looks like the NuGet.Client change was merged 12 days ago with NuGet/NuGet.Client#2131, can this be rebased and merged as well? |
@tannergooding It just got merged into the CLI yesterday: dotnet/cli#9040 So yes, I think this is unblocked now |
61be612
to
ea0b7ab
Compare
@MattGertz for approval Issues fixed Description of Issue Customer Impact Risk Testing |
@livarcocc Does this fall under the domain of .NET Shiproom? For my part, I would approve this. |
We're on the same page --- this is pending shiproom approval. |
348ca3a
to
3094758
Compare
Resolves #1486
Resolves #1438, and #1057 (it doesn't enable the scenario, but does fix the SDK's piece)
NuGet sets the
ProjectAssetsFile
property in the.g.props
file it generates, so this property should already be set by the time we would get to the code this PR removes.TODO: Test whether this affects behavior when restore hasn't occurred.