Exclude runtimeidentifiers for runtimepack #22658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Nov 18, 2021
Comment on lines
99
to
100
| HashSet<string> availableRids = new HashSet<string>(availableRuntimeIdentifiers); | ||
| HashSet<string> excludedRids = runtimeIdentifiersToExclude switch { null => null, _ => new HashSet<string>(runtimeIdentifiersToExclude) }; |
There was a problem hiding this comment.
Is it worth using the ctor for HashSet<T> where you pass a StringComparer? StringComparer.Ordinal might help performance a bit? (Or OrdinalIgnoreCase if it is correct)
sfoslund
approved these changes
Nov 18, 2021
| { | ||
| return candidateRuntimeIdentifier; | ||
| // Don't treat this as a match | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| // No compatible RID found in availableRuntimeIdentifiers |
There was a problem hiding this comment.
Looks like this comment is out of date now?
| { | ||
| var testProject = new TestProject() | ||
| { | ||
| TargetFrameworks = "net6.0", |
There was a problem hiding this comment.
nit: don't we have a current framework field now to make it easier to update test TFMs?
dsplaisted
force-pushed
the
exclude-runtimeidentifiers-for-runtimepack
branch
from
2dc6156 to
840292f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow RuntimeIdentifiers to be excluded from runtime packs.
Will fix #19891, once we add
RuntimePackExcludedRuntimeIdentifiers="android"to the ASP.NET KnownFrameworkReference items.Also fixes an unrelated issue where ResolveAppHosts would generate errors in debug mode because it was generating messages prefixed with NETSDK error codes.