Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume basline capabilities #23185

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Conversation

pranavkm
Copy link
Contributor

In a Blazor app, the apply-update capabilities are available after the app is up and running in the browser.
Occasionally it takes long for the app to start up and our baseline task times out. Currently we return an empty
list of capabilities which causes the compiler to produce no deltas. This PR bumps up the timeout ever so slightly
and returns baseline capabilities instead.

Fixes dotnet/aspnetcore#36723

In a Blazor app, the apply-update capabilities are available after the app is up and running in the browser.
Occasionally it takes long for the app to start up and our baseline task times out. Currently we return an empty
list of capabilities which causes the compiler to produce no deltas. This PR bumps up the timeout ever so slightly
and returns baseline capabilities instead.

Fixes dotnet/aspnetcore#36723
@dotnet-issue-labeler dotnet-issue-labeler bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Dec 27, 2021
@pranavkm pranavkm enabled auto-merge (squash) December 30, 2021 17:09
@pranavkm pranavkm merged commit 2e4804d into main Dec 30, 2021
pranavkm added a commit that referenced this pull request Jan 3, 2022
In a Blazor app, the apply-update capabilities are available after the app is up and running in the browser.
Occasionally it takes long for the app to start up and our baseline task times out. Currently we return an empty
list of capabilities which causes the compiler to produce no deltas. This PR bumps up the timeout ever so slightly
and returns baseline capabilities instead.

Fixes dotnet/aspnetcore#36723
@pranavkm pranavkm deleted the prkrishn/assume-baseline-capabilities branch January 3, 2022 19:22
pranavkm added a commit that referenced this pull request Jan 3, 2022
* Assume basline capabilities (#23185)

In a Blazor app, the apply-update capabilities are available after the app is up and running in the browser.
Occasionally it takes long for the app to start up and our baseline task times out. Currently we return an empty
list of capabilities which causes the compiler to produce no deltas. This PR bumps up the timeout ever so slightly
and returns baseline capabilities instead.

Fixes dotnet/aspnetcore#36723

* Use project path instead of working directory to resolve launchSettings.json (#23184)

* Use project path instead of working directory to resolve launchSettings.json

Fixes dotnet/aspnetcore#35393

* Update DotNetWatcherTests.cs
@szalapski
Copy link

Is this in the shipped product? What version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dotnet-watch] Hot reload capabilities are sometimes not reported for blazor-wasm
2 participants