Rename "NetSdkManaged" types to "FileBased"

[gkulin]

Fixes #23758

[dnfadmin]

All CLA requirements met.

[dsplaisted]

@dotnet/nuget-team We had a test fail with the following error:

/private/tmp/helix/working/B17F0976/p/d/sdk/6.0.300-ci/NuGet.targets(564,5): error : The process cannot access the file '/private/tmp/helix/working/B17F0976/w/A8740934/e/testExecutionDirectory/.dotnet/.nuget/NuGet/nugetorgadd.trk' because it is being used by another process. [/private/tmp/helix/working/B17F0976/w/A8740934/e/testExecutionDirectory/It_publishes_---B5C78A02/Library/Library.csproj]

Do you know what the nugetoradd.trk file is? Is there possibly a bug in NuGet with concurrent access to that file?

[joeloff]

@dotnet/nuget-team We had a test fail with the following error:

/private/tmp/helix/working/B17F0976/p/d/sdk/6.0.300-ci/NuGet.targets(564,5): error : The process cannot access the file '/private/tmp/helix/working/B17F0976/w/A8740934/e/testExecutionDirectory/.dotnet/.nuget/NuGet/nugetorgadd.trk' because it is being used by another process. [/private/tmp/helix/working/B17F0976/w/A8740934/e/testExecutionDirectory/It_publishes_---B5C78A02/Library/Library.csproj]

Do you know what the nugetoradd.trk file is? Is there possibly a bug in NuGet with concurrent access to that file?

MSBuild had a similar/related issue: dotnet/msbuild#3925 (comment)

[zivkan]

nugetoradd.trk is to mitigate Chocolately and Windows PowerShell's PowerShellGallery module creating a user-profile nuget.config without nuget.org as a package source, which confused many customers using these two tools before using dotnet or Visual Studio for the first time on a clean devbox. For more information: NuGet/Home#11387

Perhaps there's an issue with the implementation. By any chance, on the machines where it's failing, are they running tests in parallel, without ever having run dotnet build or dotnet restore once before running the tests? My guess is that the machine doesn't yet have the user-profile nuget.config or nugetorgadd.trk, and then running multiple processes at the same time that use NuGet.

[marcpopMSFT]

Should we consider adding a dotnet build call to the RunTestsOnHelix.* scripts that runs before our helix tests get launched? That could potentially work around this if @zivkan's assumption is accurate.

[zivkan]

dotnet nuget list source is sufficient for NuGet to create the default config (and nuget.org tracking file).