Feature band fallback with workload update #24678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
reviewed
May 10, 2022
src/Tests/dotnet-workload-install.Tests/GivenWorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
gkulin
requested review from
a team,
dsplaisted and
joeloff
and removed request for
a team
joeloff
reviewed
May 13, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
…b.com/gkulin/sdk into featureBandFallbackWithWorkloadUpdate
joeloff
reviewed
May 13, 2022
| @@ -366,6 +366,8 @@ public void ApplyRollbackAcrossFeatureBand(string existingSdkFeatureBand, string | |||
| packInstaller.InstalledManifests[0].manifestUpdate.ManifestId.Should().Be(manifestsToUpdate[0].manifestUpdate.ManifestId); | |||
| packInstaller.InstalledManifests[0].manifestUpdate.NewVersion.Should().Be(manifestsToUpdate[0].manifestUpdate.NewVersion); | |||
| packInstaller.InstalledManifests[0].manifestUpdate.NewFeatureBand.Should().Be(manifestsToUpdate[0].manifestUpdate.NewFeatureBand); | |||
| packInstaller.InstalledManifests[0].manifestUpdate.ExistingVersion.Should().Be(manifestsToUpdate[0].manifestUpdate.ExistingVersion); | |||
There was a problem hiding this comment.
Question: Before the change, were these values not set, or did they have different values?
There was a problem hiding this comment.
These values were introduced in this PR from Daniel: #24630
If I remember correctly, Daniel asked me to add these checks because his change was made after the PR where I originally wrote this test
joeloff
approved these changes
May 13, 2022
dsplaisted
approved these changes
May 16, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
src/Tests/dotnet-workload-install.Tests/MockNuGetPackageInstaller.cs
Outdated
Show resolved
Hide resolved
dsplaisted
approved these changes
May 17, 2022
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadManifestUpdater.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23403