-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apphost customization #2545
Merged
Merged
Commits on Sep 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dcacdc0 - Browse repository at this point
Copy the full SHA dcacdc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25bb0d6 - Browse repository at this point
Copy the full SHA 25bb0d6View commit details
Commits on Sep 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0bf8fa5 - Browse repository at this point
Copy the full SHA 0bf8fa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 888026b - Browse repository at this point
Copy the full SHA 888026bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e776e9 - Browse repository at this point
Copy the full SHA 2e776e9View commit details -
Check PE image and host to provide appropriate warning
This will emit a warning if host customization is requested but we are building on non-Windows (where the required APIs don't exist).
Configuration menu - View commit details
-
Copy full SHA for 6e40454 - Browse repository at this point
Copy the full SHA 6e40454View commit details
Commits on Sep 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f61feae - Browse repository at this point
Copy the full SHA f61feaeView commit details
Commits on Sep 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7a342b5 - Browse repository at this point
Copy the full SHA 7a342b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0574dcc - Browse repository at this point
Copy the full SHA 0574dccView commit details
Commits on Sep 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e8fcf28 - Browse repository at this point
Copy the full SHA e8fcf28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 156e0c3 - Browse repository at this point
Copy the full SHA 156e0c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5833c67 - Browse repository at this point
Copy the full SHA 5833c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for b029ce0 - Browse repository at this point
Copy the full SHA b029ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c455384 - Browse repository at this point
Copy the full SHA c455384View commit details
Commits on Sep 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ecba305 - Browse repository at this point
Copy the full SHA ecba305View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49ee502 - Browse repository at this point
Copy the full SHA 49ee502View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f4c1e - Browse repository at this point
Copy the full SHA 20f4c1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4199da9 - Browse repository at this point
Copy the full SHA 4199da9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af93e1 - Browse repository at this point
Copy the full SHA 3af93e1View commit details -
Don't throw managed exceptions from callbacks
Instead, use the extra parameter to capture error information, and throw the appropriate error from the caller of EnumResourceTypes.
Configuration menu - View commit details
-
Copy full SHA for ea4f506 - Browse repository at this point
Copy the full SHA ea4f506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 982d4ab - Browse repository at this point
Copy the full SHA 982d4abView commit details
Commits on Sep 27, 2018
-
Separate _CreateAppHost from _ComputeNETCoreBuildOutputFiles
This cuts the dependency from _ComputeNETCoreBuildOutputFiles on CoreCompile. Instead, _CreateAppHost will run after compilation via CompileDependson. Locating the restored apphost has been factored into another target _GetAppHostPaths, which is a dependency of both _ComputeNETCoreBuildOutputFiles and _CreateAppHost. The destination apphost path is also computed here, and passed to the CreateAppHost task as an input. This way, during a "publish --no-build", the apphost destintation path (of the previously-generated apphost) is computed as a dependency of _ComputeNETCoreBuildOutputFiles, and it is copied to the publish directory without causing CoreCompile to run.
Configuration menu - View commit details
-
Copy full SHA for 38d485a - Browse repository at this point
Copy the full SHA 38d485aView commit details
Commits on Oct 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9e5b84b - Browse repository at this point
Copy the full SHA 9e5b84bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 801cacd - Browse repository at this point
Copy the full SHA 801cacdView commit details -
Configuration menu - View commit details
-
Copy full SHA for dce92c7 - Browse repository at this point
Copy the full SHA dce92c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45eef49 - Browse repository at this point
Copy the full SHA 45eef49View commit details -
The apphost is (optionally) customized by copying resources from the managed dll, and setting the GUI bit based on the Target property (which also modifies the managed dll). Therefore, we use the managed dll as an input for incremental build (the apphost needs to be updated iff the managed dll was updated). This fixes dotnet#2554. This also removes the unnecessary overwriteExisting flag from AppHost.Create, fixing dotnet#2473.
Configuration menu - View commit details
-
Copy full SHA for 677fb26 - Browse repository at this point
Copy the full SHA 677fb26View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3aba73 - Browse repository at this point
Copy the full SHA c3aba73View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.