Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apphost customization #2545

Merged
merged 28 commits into from
Oct 1, 2018
Merged

Add apphost customization #2545

merged 28 commits into from
Oct 1, 2018

Commits on Sep 14, 2018

  1. Add apphost customization

    sbomer committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    dcacdc0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25bb0d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Configuration menu
    Copy the full SHA
    0bf8fa5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    888026b View commit details
    Browse the repository at this point in the history
  3. Factor out PE image check

    sbomer committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    2e776e9 View commit details
    Browse the repository at this point in the history
  4. Check PE image and host to provide appropriate warning

    This will emit a warning if host customization is requested but we are
    building on non-Windows (where the required APIs don't exist).
    sbomer committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    6e40454 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Configuration menu
    Copy the full SHA
    f61feae View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Clean up ResourceUpdater

    Add proper error handling and documentation
    sbomer committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    7a342b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0574dcc View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. Configuration menu
    Copy the full SHA
    e8fcf28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    156e0c3 View commit details
    Browse the repository at this point in the history
  3. Add comment about PE header

    sbomer committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    5833c67 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b029ce0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c455384 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. Configuration menu
    Copy the full SHA
    ecba305 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49ee502 View commit details
    Browse the repository at this point in the history
  3. Remove AppHostOptions

    sbomer committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    20f4c1e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4199da9 View commit details
    Browse the repository at this point in the history
  5. Make ResourceUpdater internal

    sbomer committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    3af93e1 View commit details
    Browse the repository at this point in the history
  6. Don't throw managed exceptions from callbacks

    Instead, use the extra parameter to capture error information, and
    throw the appropriate error from the caller of EnumResourceTypes.
    sbomer committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    ea4f506 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    982d4ab View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2018

  1. Separate _CreateAppHost from _ComputeNETCoreBuildOutputFiles

    This cuts the dependency from _ComputeNETCoreBuildOutputFiles on
    CoreCompile. Instead, _CreateAppHost will run after compilation via
    CompileDependson.
    
    Locating the restored apphost has been factored into another target
    _GetAppHostPaths, which is a dependency of both
    _ComputeNETCoreBuildOutputFiles and _CreateAppHost. The destination
    apphost path is also computed here, and passed to the CreateAppHost
    task as an input.
    
    This way, during a "publish --no-build", the apphost destintation
    path (of the previously-generated apphost) is computed as a dependency
    of _ComputeNETCoreBuildOutputFiles, and it is copied to the publish
    directory without causing CoreCompile to run.
    sbomer committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    38d485a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. Configuration menu
    Copy the full SHA
    9e5b84b View commit details
    Browse the repository at this point in the history
  2. Make UseWindowsGraphicalUserInterface property private

    And fix a typo
    sbomer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    801cacd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dce92c7 View commit details
    Browse the repository at this point in the history
  4. Improve warning message

    sbomer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    45eef49 View commit details
    Browse the repository at this point in the history
  5. Fix apphost incremental build

    The apphost is (optionally) customized by copying resources from the
    managed dll, and setting the GUI bit based on the Target
    property (which also modifies the managed dll). Therefore, we use the
    managed dll as an input for incremental build (the apphost needs to be
    updated iff the managed dll was updated). This fixes
    dotnet#2554.
    
    This also removes the unnecessary overwriteExisting flag from
    AppHost.Create, fixing dotnet#2473.
    sbomer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    677fb26 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3aba73 View commit details
    Browse the repository at this point in the history