Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darc-Update] Update dependencies from build 20181109.22 of https://github.com/dotnet/arcade #2658

Merged
merged 4 commits into from
Nov 12, 2018
Merged

[Darc-Update] Update dependencies from build 20181109.22 of https://github.com/dotnet/arcade #2658

merged 4 commits into from
Nov 12, 2018

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This change updates the dependencies from https://github.com/dotnet/arcade to the following

  • Microsoft.AspNetCore.ApiVersioning - 1.0.0-beta.18559.22
  • symbols/Microsoft.AspNetCore.ApiVersioning.Swashbuckle.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.ApiCompat.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Arcade.Sdk.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Build.Tasks.Feed.2.2.0-beta.18559.22.symbols.nupkg - 2.2.0-beta.18559.22
  • symbols/Microsoft.DotNet.Build.Tasks.Packaging.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.CodeAnalysis.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Darc.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.DarcLib.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Deployment.Tasks.Links.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.AspNetCore.ApiVersioning.Analyzers.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.GenAPI.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Helix.Client.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Helix.JobSender.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Helix.Sdk.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Maestro.Client.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.Maestro.Tasks.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.SignCheck.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.SignTool.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.SwaggerGenerator.CmdLine.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.SwaggerGenerator.MSBuild.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.GenFacades.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • symbols/Microsoft.DotNet.XUnitExtensions.2.4.0-beta.18559.22.symbols.nupkg - 2.4.0-beta.18559.22
  • symbols/Microsoft.AspNetCore.ApiVersioning.1.0.0-beta.18559.22.symbols.nupkg - 1.0.0-beta.18559.22
  • Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.18559.22
  • Microsoft.AspNetCore.ApiVersioning.Analyzers - 1.0.0-beta.18559.22
  • Microsoft.AspNetCore.ApiVersioning.Swashbuckle - 1.0.0-beta.18559.22
  • Microsoft.DotNet.ApiCompat - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.18559.22
  • Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.18559.22
  • Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Darc - 1.0.0-beta.18559.22
  • Microsoft.DotNet.DarcLib - 1.0.0-beta.18559.22
  • Microsoft.DotNet.XUnitExtensions - 2.4.0-beta.18559.22
  • Microsoft.DotNet.Deployment.Tasks.Links - 1.0.0-beta.18559.22
  • Microsoft.DotNet.GenFacades - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Helix.Client - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Helix.JobSender - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Maestro.Client - 1.0.0-beta.18559.22
  • Microsoft.DotNet.Maestro.Tasks - 1.0.0-beta.18559.22
  • Microsoft.DotNet.SignCheck - 1.0.0-beta.18559.22
  • Microsoft.DotNet.SignTool - 1.0.0-beta.18559.22
  • Microsoft.DotNet.SwaggerGenerator.CmdLine - 1.0.0-beta.18559.22
  • Microsoft.DotNet.GenAPI - 1.0.0-beta.18559.22

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 10, 2018 •
edited
Loading

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded

@livarcocc
Copy link
Contributor

@chcosta Something has changed in arcade that is causing our windows builds to fail due to signing. Can you investigate and make a fix recommendation?

@livarcocc livarcocc added this to the 3.0.1xx milestone Nov 10, 2018
@livarcocc
Copy link
Contributor

Also, how can we investigate why we didn't get a SDK insertion as well, automatically?

@chcosta
Copy link
Member

chcosta commented Nov 12, 2018

I'll start a mail thread and loop in Cesar regarding the signing failure (I don't seem to be able to tag him in this repo).

@chcosta
Copy link
Member

chcosta commented Nov 12, 2018

Also, how can we investigate why we didn't get a SDK insertion as well, automatically?

Do you mean an Arcade SDK update?

@JohnTortugo
Copy link
Contributor

Hey, this problem is due to a recent update that check if we are trying to sign a "non-Microsoft" (as per the Copyright string in the assembly) with a Microsoft certificate.

To fix that we need to explicitly configure SignTool to sign these files with a third party certificate. For instance, here is how we do it for Arcade: https://github.com/dotnet/arcade/blob/83ae1a636871cf7f2f4d229047c6535ace11081c/eng/Signing.props#L15

Some files (e.g., Microsoft.DotNet.Cli.Utils.resources.dll) might be actually Microsoft ones but the tool currently assumes they aren't, because the empty copyright string. We are aware of that problem and plan to work on it soon: dotnet/arcade#1295

I'll make a patch for this branch in a few minutes.

@JohnTortugo
Copy link
Contributor

I got permission denied to push to this branch. I just need to push the file below to eng/ folder.

<Project>
  <ItemGroup>
    <!-- 
      Suppresses code signing on this file because it causes a false-positive on SIGN001.
    -->
    <FileSignInfo Include="Microsoft.DotNet.Cli.Utils.resources.dll" CertificateName="None" />
  </ItemGroup>

  <!--
    These are third party libraries that we use in Arcade. We need to sign them even if they
    are already signed. However, they must be signed with a 3rd party certificate.
  -->
  <ItemGroup>
    <FileSignInfo Include="Newtonsoft.Json.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="CommandLine.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="FluentAssertions.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="FluentAssertions.Core.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="FluentAssertions.Json.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="Microsoft.3rdpartytools.MarkdownLog.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="xunit.performance.api.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="xunit.performance.core.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="xunit.performance.execution.dll" CertificateName="3PartySHA2" />
    <FileSignInfo Include="xunit.performance.metrics.dll" CertificateName="3PartySHA2" />
  </ItemGroup>
</Project>

@livarcocc
Copy link
Contributor

@JohnTortugo can you try again. I gave you write permissions to the branch.

@JohnTortugo
Copy link
Contributor

Thanks @livarcocc . Pushed the file.

@dotnet-maestro dotnet-maestro bot merged commit 6d03d9a into master Nov 12, 2018
@dotnet-maestro dotnet-maestro bot deleted the darc-master-403bbe3d-db6b-4b71-9a3d-e05e5248da9a branch November 12, 2018 20:56
wli3 pushed a commit that referenced this pull request Feb 7, 2020
@dotnet-maestro
Update dependencies from https://github.com/dotnet/cli build 20190906…
57fa869 
….7 (#2658)

- Microsoft.DotNet.Cli.Runtime - 3.0.100-rc2.19456.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@livarcocc livarcocc livarcocc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1xx
Development

Successfully merging this pull request may close these issues.
3 participants
@livarcocc @chcosta @JohnTortugo