Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #27149

Merged
merged 25 commits into from
Aug 23, 2022
Merged

[main] Update dependencies from dotnet/runtime #27149

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
50d8a9f
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 13, 2022
f4b957c
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 14, 2022
9f9464b
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 15, 2022
c830a4f
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 16, 2022
149b6d3
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 17, 2022
7d38384
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 18, 2022
d3fc84d
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 18, 2022
8119940
Fix consumption of dotnet/runtime after branding switch to 8.0
jkoritzinsky Aug 18, 2022
3ed958e
Remove pinned package references. Now that HostModel is using 6.0.0 a…
jkoritzinsky Aug 18, 2022
c237c8e
Merge branch 'main' of github.com:dotnet/sdk into darc-main-b89ef279-…
jkoritzinsky Aug 18, 2022
4ddab3c
Update Blazor WASM Baselines for new files (#27201)
TanayParikh Aug 18, 2022
37f6666
Revert "Remove pinned package references. Now that HostModel is using…
jkoritzinsky Aug 19, 2022
d9a2f43
Rev HostModel dependencies' versions
am11 Aug 18, 2022
c53cffb
Bump global SystemReflectionMetadataVersion
MichalStrehovsky Aug 19, 2022
954e9bc
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 20, 2022
c3a59e8
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 21, 2022
c1b3ba8
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 22, 2022
92d7d09
Fix mismatched runtime versions
jkoritzinsky Aug 22, 2022
2d19ab8
Remove js-module-crypto handling in the SDK
eerhardt Aug 19, 2022
3308817
Update dependencies from https://github.com/dotnet/runtime build 2022…
dotnet-maestro[bot] Aug 23, 2022
a3d3230
Update ASP.NET baselines for latest runtime version
eerhardt Aug 23, 2022
098e370
Fix mismatched runtime versions
eerhardt Aug 23, 2022
eb5ed3b
Revert "Bump global SystemReflectionMetadataVersion"
eerhardt Aug 23, 2022
e552c9b
Pin version to 6.0.0. This solves the binding redirect issue by ensur…
jkoritzinsky Aug 23, 2022
8cd88bb
Merge branch 'darc-main-b89ef279-c278-4e48-9a05-29840bb46c47' of gith…
jkoritzinsky Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,41 +6,41 @@
<Sha>e8d0d49d55528cb91179033abf474610cc5e326c</Sha>
<SourceBuild RepoName="templating" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Ref" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.NETCore.App.Ref" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.7.0" Version="7.0.0-rc.1.22411.12">
<Dependency Name="VS.Redist.Common.NetCore.SharedFramework.x64.8.0" Version="8.0.0-alpha.1.22417.17">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>7d981168a2a2ed7d2190776a08ece88665cba727</Sha>
</Dependency>
<Dependency Name="VS.Redist.Common.NetCore.TargetingPack.x64.7.0" Version="7.0.0-rc.1.22411.12">
<Dependency Name="VS.Redist.Common.NetCore.TargetingPack.x64.8.0" Version="8.0.0-alpha.1.22417.17">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>7d981168a2a2ed7d2190776a08ece88665cba727</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.NETCore.App.Runtime.win-x64" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Host.win-x64" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.NETCore.App.Host.win-x64" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.Platforms" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.NETCore.Platforms" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.HostModel" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.NET.HostModel" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.Extensions.DependencyModel" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.Extensions.DependencyModel" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.DotNetHostResolver" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.NETCore.DotNetHostResolver" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.Build" Version="17.4.0-preview-22416-02">
<Uri>https://github.com/dotnet/msbuild</Uri>
Expand Down Expand Up @@ -110,44 +110,44 @@
<Sha>6252a2194dd32911db2c0669fc818555687d5570</Sha>
<SourceBuild RepoName="linker" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.DotNet.ILCompiler" Version="7.0.0-rc.1.22411.12">
<Dependency Name="Microsoft.DotNet.ILCompiler" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
<SourceBuildTarball RepoName="runtime" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.NET.ILLink.Analyzers" Version="7.0.100-1.22415.4">
<Uri>https://github.com/dotnet/linker</Uri>
<Sha>6252a2194dd32911db2c0669fc818555687d5570</Sha>
</Dependency>
<Dependency Name="System.CodeDom" Version="7.0.0-rc.1.22411.12">
<Dependency Name="System.CodeDom" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="System.Security.Cryptography.ProtectedData" Version="7.0.0-rc.1.22411.12">
<Dependency Name="System.Security.Cryptography.ProtectedData" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="System.Text.Encoding.CodePages" Version="7.0.0-rc.1.22411.12">
<Dependency Name="System.Text.Encoding.CodePages" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="System.Resources.Extensions" Version="7.0.0-rc.1.22411.12">
<Dependency Name="System.Resources.Extensions" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.WindowsDesktop.App.Runtime.win-x64" Version="8.0.0-alpha.1.22416.7">
<Uri>https://github.com/dotnet/windowsdesktop</Uri>
<Sha>d84ac6d64ab97febc153dfa903b52a828f47f44d</Sha>
</Dependency>
<Dependency Name="VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0" Version="7.0.0-rc.1.22415.6">
<Dependency Name="VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0" Version="8.0.0-alpha.1.22416.7">
<Uri>https://github.com/dotnet/windowsdesktop</Uri>
<Sha>1ce737df56e7c14e2ba7adb308d9c045d6d67a8c</Sha>
</Dependency>
<Dependency Name="Microsoft.WindowsDesktop.App.Ref" Version="8.0.0-alpha.1.22416.7">
<Uri>https://github.com/dotnet/windowsdesktop</Uri>
<Sha>d84ac6d64ab97febc153dfa903b52a828f47f44d</Sha>
</Dependency>
<Dependency Name="VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0" Version="7.0.0-rc.1.22415.6">
<Dependency Name="VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0" Version="8.0.0-alpha.1.22416.7">
<Uri>https://github.com/dotnet/windowsdesktop</Uri>
<Sha>1ce737df56e7c14e2ba7adb308d9c045d6d67a8c</Sha>
</Dependency>
Expand All @@ -167,7 +167,7 @@
<Uri>https://github.com/dotnet/aspnetcore</Uri>
<Sha>0563a6a2797b96455a80437217f0c55653f21553</Sha>
</Dependency>
<Dependency Name="VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0" Version="7.0.0-rc.1.22416.5">
<Dependency Name="VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0" Version="8.0.0-alpha.1.22417.14">
<Uri>https://github.com/dotnet/aspnetcore</Uri>
<Sha>77ea9ee147f495dd05a1d50906e3d455a5f4f2a0</Sha>
<SourceBuild RepoName="aspnetcore" ManagedOnly="true" />
Expand Down Expand Up @@ -279,9 +279,9 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>6a638cd0c13962ab2a1943cb1c878be5a41dd82e</Sha>
</Dependency>
<Dependency Name="System.Reflection.MetadataLoadContext" Version="7.0.0-rc.1.22411.12">
<Dependency Name="System.Reflection.MetadataLoadContext" Version="8.0.0-alpha.1.22421.15">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>f52d8c59bb49360eb2cbeeb863c5856ebd62adda</Sha>
<Sha>f6166429381a4205207930d673c86a35da9ff40f</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.22409.1" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
<Uri>https://github.com/dotnet/xliff-tasks</Uri>
Expand Down
26 changes: 13 additions & 13 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,29 +32,29 @@
<NewtonsoftJsonVersion>$(NewtonsoftJsonPackageVersion)</NewtonsoftJsonVersion>
<SystemCollectionsImmutableVersion>6.0.0</SystemCollectionsImmutableVersion>
<SystemDiagnosticsFileVersionInfoVersion>4.0.0</SystemDiagnosticsFileVersionInfoVersion>
<SystemReflectionMetadataVersion>6.0.0</SystemReflectionMetadataVersion>
<SystemReflectionMetadataVersion>6.0.1</SystemReflectionMetadataVersion>
<MicrosoftDotNetSignToolVersion>7.0.0-beta.22411.2</MicrosoftDotNetSignToolVersion>
<MicrosoftWebXdtPackageVersion>3.1.0</MicrosoftWebXdtPackageVersion>
<SystemSecurityCryptographyProtectedDataPackageVersion>7.0.0-rc.1.22411.12</SystemSecurityCryptographyProtectedDataPackageVersion>
<SystemSecurityCryptographyProtectedDataPackageVersion>8.0.0-alpha.1.22421.15</SystemSecurityCryptographyProtectedDataPackageVersion>
<SystemCollectionsSpecializedPackageVersion>4.3.0</SystemCollectionsSpecializedPackageVersion>
<SystemXmlXmlDocumentPackageVersion>4.3.0</SystemXmlXmlDocumentPackageVersion>
<WebDeploymentPackageVersion>4.0.5</WebDeploymentPackageVersion>
<SystemTextJsonVersion>6.0.0</SystemTextJsonVersion>
<SystemReflectionMetadataLoadContextVersion>7.0.0-rc.1.22411.12</SystemReflectionMetadataLoadContextVersion>
<SystemReflectionMetadataLoadContextVersion>8.0.0-alpha.1.22421.15</SystemReflectionMetadataLoadContextVersion>
<SystemManagementPackageVersion>4.6.0</SystemManagementPackageVersion>
<SystemCommandLineVersion>2.0.0-beta4.22402.1</SystemCommandLineVersion>
<MicrosoftDeploymentDotNetReleasesVersion>1.0.0-preview5.1.22263.1</MicrosoftDeploymentDotNetReleasesVersion>
<MicrosoftVisualStudioSetupConfigurationInteropVersion>3.0.4496</MicrosoftVisualStudioSetupConfigurationInteropVersion>
</PropertyGroup>
<PropertyGroup>
<!-- Dependencies from https://github.com/dotnet/runtime -->
<MicrosoftNETCoreAppRefPackageVersion>7.0.0-rc.1.22411.12</MicrosoftNETCoreAppRefPackageVersion>
<VSRedistCommonNetCoreSharedFrameworkx6470PackageVersion>7.0.0-rc.1.22411.12</VSRedistCommonNetCoreSharedFrameworkx6470PackageVersion>
<MicrosoftNETCoreAppRuntimewinx64PackageVersion>7.0.0-rc.1.22411.12</MicrosoftNETCoreAppRuntimewinx64PackageVersion>
<MicrosoftNETCoreAppRefPackageVersion>8.0.0-alpha.1.22421.15</MicrosoftNETCoreAppRefPackageVersion>
<VSRedistCommonNetCoreSharedFrameworkx6480PackageVersion>8.0.0-alpha.1.22417.17</VSRedistCommonNetCoreSharedFrameworkx6480PackageVersion>
<MicrosoftNETCoreAppRuntimewinx64PackageVersion>8.0.0-alpha.1.22421.15</MicrosoftNETCoreAppRuntimewinx64PackageVersion>
<MicrosoftNETCoreAppRuntimePackageVersion>$(MicrosoftNETCoreAppRuntimewinx64PackageVersion)</MicrosoftNETCoreAppRuntimePackageVersion>
<MicrosoftExtensionsDependencyModelPackageVersion>7.0.0-rc.1.22411.12</MicrosoftExtensionsDependencyModelPackageVersion>
<MicrosoftNETCoreDotNetHostResolverPackageVersion>7.0.0-rc.1.22411.12</MicrosoftNETCoreDotNetHostResolverPackageVersion>
<MicrosoftNETHostModelVersion>7.0.0-rc.1.22411.12</MicrosoftNETHostModelVersion>
<MicrosoftExtensionsDependencyModelPackageVersion>8.0.0-alpha.1.22421.15</MicrosoftExtensionsDependencyModelPackageVersion>
<MicrosoftNETCoreDotNetHostResolverPackageVersion>8.0.0-alpha.1.22421.15</MicrosoftNETCoreDotNetHostResolverPackageVersion>
<MicrosoftNETHostModelVersion>8.0.0-alpha.1.22421.15</MicrosoftNETHostModelVersion>
<MicrosoftExtensionsFileSystemGlobbingPackageVersion>6.0.0-preview.7.21363.9</MicrosoftExtensionsFileSystemGlobbingPackageVersion>
<MicrosoftExtensionsDependencyModelVersion>$(MicrosoftExtensionsDependencyModelPackageVersion)</MicrosoftExtensionsDependencyModelVersion>
<MicrosoftExtensionsLoggingConsoleVersion>6.0.0</MicrosoftExtensionsLoggingConsoleVersion>
Expand Down Expand Up @@ -90,10 +90,10 @@
</PropertyGroup>
<PropertyGroup>
<!-- Dependencies from https://github.com/dotnet/runtime -->
<SystemCodeDomPackageVersion>7.0.0-rc.1.22411.12</SystemCodeDomPackageVersion>
<SystemTextEncodingCodePagesPackageVersion>7.0.0-rc.1.22411.12</SystemTextEncodingCodePagesPackageVersion>
<SystemResourcesExtensionsPackageVersion>7.0.0-rc.1.22411.12</SystemResourcesExtensionsPackageVersion>
<MicrosoftDotNetILCompilerPackageVersion>7.0.0-rc.1.22411.12</MicrosoftDotNetILCompilerPackageVersion>
<SystemCodeDomPackageVersion>8.0.0-alpha.1.22421.15</SystemCodeDomPackageVersion>
<SystemTextEncodingCodePagesPackageVersion>8.0.0-alpha.1.22421.15</SystemTextEncodingCodePagesPackageVersion>
<SystemResourcesExtensionsPackageVersion>8.0.0-alpha.1.22421.15</SystemResourcesExtensionsPackageVersion>
<MicrosoftDotNetILCompilerPackageVersion>8.0.0-alpha.1.22421.15</MicrosoftDotNetILCompilerPackageVersion>
</PropertyGroup>
<PropertyGroup>
<!-- Dependencies from https://github.com/dotnet/format -->
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"dotnet": "7.0.100-preview.5.22307.18",
"runtimes": {
"dotnet": [
"$(VSRedistCommonNetCoreSharedFrameworkx6470PackageVersion)"
"$(VSRedistCommonNetCoreSharedFrameworkx6480PackageVersion)"
]
},
"vs-opt": {
Expand Down
13 changes: 6 additions & 7 deletions src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageId>Microsoft.NET.Sdk</PackageId>
<OutDirName>$(Configuration)\Sdks\$(PackageId)\tools</OutDirName>
</PropertyGroup>

<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />

<PropertyGroup>
Expand Down Expand Up @@ -63,12 +63,11 @@
<!-- Packages that are in-box for .NET Core, so we only need to reference them for .NET Framework -->
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' and '$(DotNetBuildFromSource)' != 'true'">
<!--
MSBuild depends on a new version of SRM/SCI; HostModel a very old one.
In order to keep working with MSBuild 17.2, which had binding redirects
for SCI 0-5.0.0.0 but not 6, this task must compile against 5, even
though that's not the very latest. -->
<PackageReference Include="System.Collections.Immutable" Version="5.0.0" />
<PackageReference Include="System.Reflection.Metadata" Version="5.0.0" />
MSBuild depends on a new version of SRM/SCI; keep in sync with binding redirect:
https://github.com/dotnet/msbuild/blob/5d102ae37163fc1f22610bb433c3ab9a2fff91f0/src/MSBuild/app.config#L59
-->
<PackageReference Include="System.Collections.Immutable" Version="$(SystemCollectionsImmutableVersion)" />
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataVersion)" />
MichalStrehovsky marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on vacation; what was the specific motivation/break fix for this change?

I think it's ok to go forward with this because we shouldn't care about 17.2 any more, and as long as this moves ahead of MSBuild there should be no problem with adopting a higher version (as long as the task ships both of these assemblies). The MSBuild.exe regression tests should catch a problem if there is one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were trying to get rid of some old pinned dependencies in dotnet/runtime. The Microsoft.NET.HostModel library was referencing an old version of System.Reflection.Metadata to avoid a break that happened 2 years ago, so we were trying to upgrade it as we felt the break was likely fixed. This particular change is undoing a fix that the SDK repo did to mitigate an issue that came up because the Microsoft.NET.HostModel library was referencing an old version of System.Reflection.Metadata (which as mentioned above, was to avoid an earlier break in the sdk).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would recommend deleting the comment entirely; they shouldn't be special any more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the MSBuild binding redirects are actually a little out of date again. They need to be updated for the System.Reflection.Metadata 6.0.1 package (new upper bound assembly version needs to be 6.0.0.1).

In the meantime, (to unblock this PR), I'm going to try to pin this to reference 6.0.0.

To avoid keeping this bad state around, I'll follow up with a PR to MSBuild to update the app.config's binding redirects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a PR to MSBuild with the updated redirect: dotnet/msbuild#7904

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the MSBuild binding redirects need to match the reference in the task here from SDK? Are the SDK tasks not delivering SRM.dll?

</ItemGroup>

<!-- These are loaded from the CLI's copy on .NET Core, we don't need to duplicate them on disk -->
Expand Down
Loading