Produce a warning and ignore Prefer32Bit for netcoreapp #27776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
vitek-karas
approved these changes
Sep 9, 2022
|
Thanks!! |
VSadov
added a commit
to VSadov/sdk
that referenced
this pull request
Sep 11, 2022
* Check for and switch off Prefer32Bit for >= 7.0 * add Prefer32Bit in the test * added a distinct warning message
VSadov
added a commit
to VSadov/sdk
that referenced
this pull request
Sep 12, 2022
* Check for and switch off Prefer32Bit for >= 7.0 * add Prefer32Bit in the test * added a distinct warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:dotnet/runtime#70776
Prefer32Bitis a way to control how OS loader loads a managed.exe. It does not make sense for a.dlland the loader would refuse to load such.dll.For netcoreapp target
Prefer32Bitresults in an app that cannot run.With this change we produce a warning when building for netcoreapp >= 7.0 target and ignore the setting.