-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated] Merge branch 'release/7.0.1xx' => 'release/7.0.2xx' #28398
[automated] Merge branch 'release/7.0.1xx' => 'release/7.0.2xx' #28398
Conversation
…007.2 Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler From Version 7.0.0-beta.22506.5 -> To Version 7.0.0-beta.22507.2
…1007.1 Microsoft.Build , Microsoft.Build.Localization From Version 17.5.0-preview-22506-03 -> To Version 17.5.0-preview-22507-01
…1007.2 Microsoft.Build , Microsoft.Build.Localization From Version 17.5.0-preview-22506-03 -> To Version 17.5.0-preview-22507-02
…0221007.11 Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks From Version 7.0.100-rtm.22507.5 -> To Version 7.0.100-rtm.22507.11
…f863-865a-4a99-beb2-a5743817dbbf [release/7.0.1xx] Update dependencies from dotnet/msbuild
…1007.3 Microsoft.Build , Microsoft.Build.Localization From Version 17.5.0-preview-22507-02 -> To Version 17.5.0-preview-22507-03
…1007.4 Microsoft.Build , Microsoft.Build.Localization From Version 17.5.0-preview-22507-03 -> To Version 17.5.0-preview-22507-04
…ests-GetUpdatedWorklads Fix checking for updated workload packs in advertising manifests
…007.6 Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler From Version 7.0.0-beta.22506.5 -> To Version 7.0.0-beta.22507.6
…14e3-2a33-47e7-a986-ec0dd6d6be14 [release/7.0.1xx] Update dependencies from dotnet/msbuild
…a4bd-da17-4e7a-9d34-c0ae91b95578 [release/7.0.1xx] Update dependencies from dotnet/templating
…n-7.0.1xx [release/7.0.1xx] Disable msbuild server by default
…2447-eb0f-48c2-b2c3-dd612c16100d [release/7.0.1xx] Update dependencies from dotnet/fsharp
fe9bea7
to
09b638c
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -16,7 +16,7 @@ namespace Microsoft.DotNet.Cli.Utils | |||
internal class MSBuildForwardingAppWithoutLogging | |||
{ | |||
private static readonly bool AlwaysExecuteMSBuildOutOfProc = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_RUN_MSBUILD_OUTOFPROC"); | |||
private static readonly bool UseMSBuildServer = !Env.GetEnvironmentVariableAsBool("DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER"); | |||
private static readonly bool UseMSBuildServer = Env.GetEnvironmentVariableAsBool("DOTNET_CLI_USE_MSBUILD_SERVER", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baronfel FYI, is this change supposed to flow forward to 7.0.2xx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - we wantMSBuild server to be opt-in for the whole 7 family of releases. We'll probably end up targeting 8 to make it out-out again, but that's all pending further discussion and investigation of the impacts.
I detected changes in the release/7.0.1xx branch which have not been merged yet to release/7.0.2xx. I'm a robot and am configured to help you automatically keep release/7.0.2xx up to date, so I've opened this PR.
This PR merges commits made on release/7.0.1xx by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/7.0.1xx-to-release/7.0.2xx'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.