[main] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: 03acf5d2-59bd-494b-c390-08d8e9750d9d
• Build: 20221019.12
• Date Produced: October 19, 2022 11:20:58 PM UTC
• Commit: 50b404de631906144f43261fa1abeae8f40b75ef
• Branch: refs/heads/main-vs-deps

• Updates:
  • Microsoft.CodeAnalysis: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12
  • Microsoft.CodeAnalysis.CSharp: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12
  • Microsoft.CodeAnalysis.CSharp.CodeStyle: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12
  • Microsoft.CodeAnalysis.CSharp.Features: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12
  • Microsoft.CodeAnalysis.CSharp.Workspaces: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12
  • Microsoft.CodeAnalysis.Workspaces.MSBuild: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12
  • Microsoft.Net.Compilers.Toolset: from 4.4.0-3.22511.14 to 4.5.0-1.22519.12

[dotnet-maestro]

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

• This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
• If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
• For more details, please read the Arcade Darc documentation

[nagilson]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[marek-safar]

There seems to be analyzer catching more mistakes in template tests or verification not excluded correctly.

@vlada-shubina @donJoseLuis could you handle this?

[vlada-shubina]

@marek-safar is there anyone from roslyn team to check these errors?

they refer to XUnit MemberData, and I believe they are false positive as there is no array in line mentioned.
Error is:

\src\Tests\dotnet-new.Tests\CommonTemplatesTests.cs(329,10): error CA1825: Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead.

Line 329 is:

sdk/src/Tests/dotnet-new.Tests/CommonTemplatesTests.cs

Line 329 in 1f666a1

[MemberData(nameof(TopLevelProgramSupport_Data))]

It looks either position or whole check is incorrect. Thank you.

[marek-safar]

@jaredpar who can follow up on Roslyn side?

[jaredpar]

@jmarolf, @333fred

The error is actually from an analyzer, not roslyn

D:\a\_work\1\s\src\Tests\Microsoft.TemplateEngine.Cli.UnitTests\ParserTests\InstantiateTests.cs(210,10): error CA1825: Avoid unnecessary zero-length array allocations.  Use Array.Empty<object>() instead

The call sites are

        [Theory]
        [MemberData(nameof(CanEvaluateTemplateToRunData))]

Which map to

        public MemberDataAttribute(string memberName, params object[] parameters)
            : base(memberName, parameters) { }

That makes me believe it's related to the following PR where we fixed a bug in IOperation that caused it to correctly hit more attribute locations. At the same time the warning seems off here. Under the hood we should be using Array<T>.Empty in the compiler (most TF support it) so not 100% sure what is going on here.

[marcpopMSFT]

Same failure in #28519

[333fred]

It's a false-postive fixed by dotnet/roslyn-analyzers#6114. The version of analyzers used will need be updated to include that fix.

[333fred]

An alternative solution to quickly unblock is to suppress these false positives. That's what we did with the VS build.