[release/7.0.1xx] Update dependencies from dotnet/arcade #28591

dotnet-maestro · 2022-10-14T16:12:52Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 2b57cf1e-5efe-45fe-1396-08da7ef5fa55
Build: 20221108.4
Date Produced: November 8, 2022 7:03:36 PM UTC
Commit: 3f3c360819c5c092d0e4505a67dfe59a33fba557
Branch: refs/heads/release/7.0

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 7.0.0-beta.22464.4 to 7.0.0-beta.22558.4
- Microsoft.DotNet.Helix.Sdk: from 7.0.0-beta.22464.4 to 7.0.0-beta.22558.4
- Microsoft.DotNet.SignTool: from 7.0.0-beta.22464.4 to 7.0.0-beta.22558.4
- Microsoft.DotNet.XUnitExtensions: from 7.0.0-beta.22464.4 to 7.0.0-beta.22558.4

Updates to .NET SDKs:
- Updates tools.dotnet to 7.0.100

…013.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22464.4 -> To Version 7.0.0-beta.22513.4

marcpopMSFT · 2022-10-19T20:25:09Z

@dotnet/aspnet-blazor-eng as there are a bunch of Blazor test failures

TanayParikh · 2022-10-19T21:11:17Z

Taking a look.

TanayParikh · 2022-10-19T21:16:37Z

also, expected:

OriginalItemSpec: C:\h\w\B1900989\t\dotnetSdkTests\gkwdfdgc.e4b\.nuget\packages\microsoft.netcore.app.runtime.mono.browser-wasm\7.0.0\runtimes\browser-wasm\native\dotnet.js,

got

OriginalItemSpec: C:\h\w\B1900989\t\dotnetSdkTests\gkwdfdgc.e4b\.nuget\packages\microsoft.netcore.app.runtime.mono.browser-wasm\[[CustomPackageVersion]]\runtimes\browser-wasm\native\dotnet.js.

Doesn't look like it's doing the proper version interpolation.

TanayParikh · 2022-10-20T21:26:02Z

sdk/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs

Line 46 in fe5db31

    
           RuntimeVersion = testAssemblyMetadata.SingleOrDefault(a => a.Key == "NetCoreAppRuntimePackageVersion").Value;

is reporting 7.0.0 instead of 7.0.0-rc.2.22472.3, which is causing the interpolation to fail.

Just re-running the baselines results in an update of ${RuntimeVersion} to ${RuntimeVersion}-rc.2.22472.3, which is of course not what we want.

It's unclear why the test assembly's NetCoreAppRuntimePackageVersion is reporting the incorrect runtime version. I think we've seen this previously as well.

cc/ @marcpopMSFT @javiercn ideas or thoughts on why this may be?

dotnet --info

dotnet --info
.NET SDK:
 Version:   7.0.100-dev
 Commit:    b694139691

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22000
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\sdk\7.0.100-dev\

Host:
  Version:      7.0.0
  Architecture: x64
  Commit:       cd2d837983

.NET SDKs installed:
  7.0.100-dev [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 7.0.0-rc.2.22476.2 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.5 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.2 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.0 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.8 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.1.0 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 5.0.0 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.0 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.0-rc.2.22472.3 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.0 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 7.0.0-rc.2.22472.13 [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  DOTNET_ROOT       [C:\Users\taparik\dev\sdk\artifacts\bin\redist\Debug\dotnet]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

marcpopMSFT · 2022-10-21T20:57:44Z

Can you clarify which is the incorrect value? In the SDK repo we've updated to a stable branding. In this PR, we're updating the stage 0 SDK to be the RC2 version though. Could that be the issue (ie the stable version we're building versus the unstable one we're using to build)?

TanayParikh · 2022-10-25T22:40:00Z

Could that be the issue (ie the stable version we're building versus the unstable one we're using to build)?

Ahh okay, yeah I think that's it. NetCoreAppRuntimePackageVersion is reporting the stable version being built, whereas when we run the baselines, it's utilizing the unstable RC2 that's doing the build.

cc/ @javiercn in case he can share any context on potentially running into this issue in previous releases.

TanayParikh · 2022-10-27T22:32:48Z

cc/ @javiercn if you can share any context you may have on the above.

dsplaisted · 2022-11-01T00:33:39Z

/azp run

azure-pipelines · 2022-11-01T00:33:49Z

Azure Pipelines successfully started running 1 pipeline(s).

marcpopMSFT · 2022-11-01T18:41:30Z

Any luck here? Looks like still a lot of Blazor test failures on the latest run.

TanayParikh · 2022-11-01T21:27:44Z

@javiercn can you please comment on the above?

dsplaisted · 2022-11-02T15:31:19Z

There is a regression in normalizing the TargetPlatformVersion which is causing the It_succeeds_if_windows_target_platform_version_does_not_have_trailing_zeros test to fail.

I'll work on fixing that but it looks like the Blazor tests are something different. Here's a reformatted version of one of the errors:

Expected:

Identity: C:\h\w\9DE508A6\t\dotnetSdkTests\ahet2vse.1xy\JsModules_Hos---8E53139E\blazorwasm\bin\Debug\net7.0\wwwroot_framework\dotnet.7.0.0.[[hash]].js,
SourceType: Project,
SourceId: blazorwasm,
ContentRoot: C:\h\w\9DE508A6\t\dotnetSdkTests\ahet2vse.1xy\JsModules_Hos---8E53139E\blazorwasm\bin\Debug\net7.0\publish\wwwroot,
BasePath: /,
RelativePath: _framework/dotnet.7.0.0.[[hash]].js,
AssetKind: Publish,
AssetMode: All,
AssetRole: Primary,
RelatedAsset: ,
AssetTraitName: BlazorWebAssemblyResource,
AssetTraitValue: native,
CopyToOutputDirectory: Never,
CopyToPublishDirectory: PreserveNewest,
OriginalItemSpec: C:\h\w\9DE508A6\t\dotnetSdkTests\ahet2vse.1xy\JsModules_Hos---8E53139E\blazorwasm\bin\Debug\net7.0\wwwroot_framework\dotnet.7.0.0.[[hash]].js,

Actual:

Identity: C:\h\w\9DE508A6\t\dotnetSdkTests\ahet2vse.1xy\JsModules_Hos---8E53139E\blazorwasm\bin\Debug\net7.0\wwwroot_framework\dotnet.7.0.0-rc.2.22472.3.[[hash]].js,
SourceType: Project,
SourceId: blazorwasm,
ContentRoot: C:\h\w\9DE508A6\t\dotnetSdkTests\ahet2vse.1xy\JsModules_Hos---8E53139E\blazorwasm\bin\Debug\net7.0\publish\wwwroot,
BasePath: /,
RelativePath: _framework/dotnet.7.0.0-rc.2.22472.3.[[hash]].js,
AssetKind: Publish,
AssetMode: All,
AssetRole: Primary,
RelatedAsset: ,
AssetTraitName: BlazorWebAssemblyResource,
AssetTraitValue: native,
CopyToOutputDirectory: Never,
CopyToPublishDirectory: PreserveNewest,
OriginalItemSpec: C:\h\w\9DE508A6\t\dotnetSdkTests\ahet2vse.1xy\JsModules_Hos---8E53139E\blazorwasm\bin\Debug\net7.0\wwwroot_framework\dotnet.7.0.0-rc.2.22472.3.[[hash]].js.

dougbu · 2022-11-07T19:35:07Z

@javiercn you mentioned you've been working on this PR while on build ops❔ Are you still on point❔ (I ask because Blazor issues aren't in my wheelhouse.)

…108.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22464.4 -> To Version 7.0.0-beta.22558.4

dsplaisted · 2022-11-10T17:29:19Z

I created #29009 to fix the regression in TargetPlatformVersion normalization.

dsplaisted · 2022-11-10T21:48:24Z

Looks like the Blazor failures for this PR are fixed by updating to the final 7.0.100 SDK. There's a mismatch somewhere in how the Blazor tests get the RuntimeVersion for the baselines versus what the actual runtime version is in the dogfood environment.

Depending on whether we're using preview versions, some of the packages may be downloaded by NuGet and have lowercased names, while at other times they may be shipped in the packs folder and have mixed case.

Update dependencies from https://github.com/dotnet/arcade build 20221…

b694139

…013.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22464.4 -> To Version 7.0.0-beta.22513.4

dotnet-issue-labeler bot added the Area-Infrastructure label Oct 14, 2022

nagilson approved these changes Oct 14, 2022

View reviewed changes

nagilson enabled auto-merge October 14, 2022 16:29

This was referenced Oct 15, 2022

Nuget restore error caused by 503s dotnet/arcade#11239

Closed

Tracking Nuget 429s dotnet/arcade#10885

Closed

TanayParikh mentioned this pull request Oct 25, 2022

[release/7.0.2xx] Update dependencies from dotnet/arcade #28583

Closed

Update dependencies from https://github.com/dotnet/arcade build 20221…

5f16b40

…108.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions From Version 7.0.0-beta.22464.4 -> To Version 7.0.0-beta.22558.4

dsplaisted mentioned this pull request Nov 11, 2022

Fix TargetPlatformVersion normalization for Windows #29009

Merged

dsplaisted added 2 commits November 14, 2022 11:56

Fix Blazor baselines to account for 6.0.11

aa64ef0

Make analyzer test package name comparison case insensitive

1c09325

Depending on whether we're using preview versions, some of the packages may be downloaded by NuGet and have lowercased names, while at other times they may be shipped in the packs folder and have mixed case.

dsplaisted requested review from captainsafia and mkArtakMSFT as code owners November 14, 2022 16:57

dsplaisted added 2 commits November 14, 2022 12:25

Disable tests for issue fixed in 7.0.200

f753bba

Fix typo

0ff29f8

nagilson merged commit af22f55 into release/7.0.1xx Nov 14, 2022

nagilson deleted the darc-release/7.0.1xx-4848e855-53e8-46da-b571-5cbd0ed52dc2 branch November 14, 2022 19:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/7.0.1xx] Update dependencies from dotnet/arcade #28591

[release/7.0.1xx] Update dependencies from dotnet/arcade #28591

dotnet-maestro bot commented Oct 14, 2022 •

edited

Loading

marcpopMSFT commented Oct 19, 2022

TanayParikh commented Oct 19, 2022

TanayParikh commented Oct 19, 2022

TanayParikh commented Oct 20, 2022 •

edited

Loading

marcpopMSFT commented Oct 21, 2022

TanayParikh commented Oct 25, 2022

TanayParikh commented Oct 27, 2022

dsplaisted commented Nov 1, 2022

azure-pipelines bot commented Nov 1, 2022

marcpopMSFT commented Nov 1, 2022

TanayParikh commented Nov 1, 2022

dsplaisted commented Nov 2, 2022

dougbu commented Nov 7, 2022

dsplaisted commented Nov 10, 2022

dsplaisted commented Nov 10, 2022

[release/7.0.1xx] Update dependencies from dotnet/arcade #28591

[release/7.0.1xx] Update dependencies from dotnet/arcade #28591

Conversation

dotnet-maestro bot commented Oct 14, 2022 • edited Loading

From https://github.com/dotnet/arcade

marcpopMSFT commented Oct 19, 2022

TanayParikh commented Oct 19, 2022

TanayParikh commented Oct 19, 2022

TanayParikh commented Oct 20, 2022 • edited Loading

marcpopMSFT commented Oct 21, 2022

TanayParikh commented Oct 25, 2022

TanayParikh commented Oct 27, 2022

dsplaisted commented Nov 1, 2022

azure-pipelines bot commented Nov 1, 2022

marcpopMSFT commented Nov 1, 2022

TanayParikh commented Nov 1, 2022

dsplaisted commented Nov 2, 2022

dougbu commented Nov 7, 2022

dsplaisted commented Nov 10, 2022

dsplaisted commented Nov 10, 2022

dotnet-maestro bot commented Oct 14, 2022 •

edited

Loading

TanayParikh commented Oct 20, 2022 •

edited

Loading