Improve Tests for Implicit RIDs and Libraries #28696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can probably target this to 7.0.1xx. Test changes don't have to be approved. We would probably just have to wait until the branch is open in to merge the PR, to avoid triggering unwanted builds. |
dsplaisted
reviewed
Oct 21, 2022
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileLibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileLibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishASingleFileLibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/RuntimeIdentifiersTests.cs
Outdated
Show resolved
Hide resolved
|
Will pass once #28717 is merged. cc @dsplaisted to approve. Confirmed the test failed before and passes with the newer rid inference code. |
dsplaisted
approved these changes
Nov 4, 2022
…-exe-rids-test-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #28628, this PR responds to PR feedback for tests that we didn't manage to get ready in time, as it would have delayed builds too long and we needed to get the fix in ASAP. Confirmed that the new tests fail in both regards without the change and pass in both regards (library paths and RID properties are set correctly) in the new scenario. We could target it to 7.0.1xx but I think that's locked down atm.
Drafting until 7.0.1xx changes have merged into 7.0.2xx.
cc @dsplaisted