Update version in global.json #3072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
/cc @nguerrera |
nguerrera
approved these changes
Apr 2, 2019
swaroop-sridhar
approved these changes
Apr 2, 2019
|
@dsplaisted could you take a look at why "It_discovers_assembly_parts" is failing due to update stage0? |
Member
|
It looks like this was a break in the Razor SDK, which seems to have subsequently been fixed. @fadimounir Can you try updating stage 0 to 3.0.100-preview5-011145 or later? @rynowak FYI, it looks like the Razor SDK broke by trying to add a RelatedAssemblyAttribute to 1.x apps, where it didn't exist. It looks like this has since been fixed though. |
Author
|
@dsplaisted Thanks for taking a look. I can update to a later version. |
fadimounir
force-pushed
the
UpdateVersion
branch
from
dff96fa to
f679db3
Compare
Author
|
@dsplaisted Looks like tests are still failing even with the updated version |
Merged
Member
|
@fadimounir #3107 updates stage 0 and includes a corresponding test update |
Author
|
Thanks! |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version pulls the ILLink.Tasks and Microsoft.NET.Build.Bundle packages.