Skip to content

Switching to Jobs from Phases for YAML #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnbeisner merged 5 commits into from
Apr 10, 2019
Merged

Switching to Jobs from Phases for YAML #3078

johnbeisner merged 5 commits into from
Apr 10, 2019

Conversation

@johnbeisner
Copy link
Contributor

@johnbeisner johnbeisner commented Apr 4, 2019 •
edited
Loading

Switching to Jobs from Phases for YAML and also switch to new pools.

@MattGal

@johnbeisner johnbeisner added this to the 3.0.1xx milestone Apr 4, 2019
@johnbeisner johnbeisner self-assigned this Apr 4, 2019
@johnbeisner johnbeisner mentioned this pull request Apr 4, 2019
Closed
@johnbeisner johnbeisner closed this Apr 4, 2019
@johnbeisner johnbeisner reopened this Apr 4, 2019
@johnbeisner johnbeisner closed this Apr 4, 2019
@johnbeisner johnbeisner reopened this Apr 4, 2019
@johnbeisner johnbeisner closed this Apr 5, 2019
@johnbeisner johnbeisner reopened this Apr 5, 2019
@johnbeisner johnbeisner requested a review from chcosta April 5, 2019 17:01
@johnbeisner johnbeisner changed the title [WIP] Switching to Jobs from Phases for YAML Switching to Jobs from Phases for YAML Apr 5, 2019
@johnbeisner johnbeisner requested a review from a team April 5, 2019 17:02
@johnbeisner
Copy link
Contributor Author

johnbeisner commented Apr 9, 2019

Queued build: https://dnceng.visualstudio.com/internal/_build/results?buildId=148986

MattGal
MattGal approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it works (pretty sure it does)

@johnbeisner johnbeisner merged commit 2486b2e into dotnet:master Apr 10, 2019
@chcosta
Copy link
Member

chcosta commented Apr 11, 2019

I still think this will break your docker usage - #3062 (comment)

@johnbeisner johnbeisner deleted the change_yaml_to_use_jobs branch April 23, 2019 21:59
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
@dotnet-maestro @wtgodbe
Update dependencies from https://github.com/aspnet/websdk build 20191…
52dc2dc 
…004.2 (dotnet#3078)

- Microsoft.NET.Sdk.Web - 3.1.100-preview1.19504.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattGal MattGal MattGal approved these changes

@chcosta chcosta Awaiting requested review from chcosta

Assignees

@johnbeisner johnbeisner

Labels

Infrastructure

Projects

None yet

Milestone

3.0.1xx

Development

Successfully merging this pull request may close these issues.

3 participants

@johnbeisner @chcosta @MattGal