Adding PublishItemsOutputGroup to support VS installer projects #3079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utputGroup Adding NetCorePublishItemsOutputGroup to support VS installer project scenarios
|
|
nguerrera
reviewed
Apr 5, 2019
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
Contributor
dasMulli
reviewed
Apr 5, 2019
src/Tests/Microsoft.NET.Publish.Tests/NetCorePublishItemsOutputGroupTests.cs
Outdated
Show resolved
Hide resolved
peterhuene
reviewed
Apr 5, 2019
src/Tests/Microsoft.NET.Publish.Tests/NetCorePublishItemsOutputGroupTests.cs
Outdated
Show resolved
Hide resolved
peterhuene
reviewed
Apr 5, 2019
src/Tests/Microsoft.NET.Publish.Tests/NetCorePublishItemsOutputGroupTests.cs
Outdated
Show resolved
Hide resolved
peterhuene
reviewed
Apr 5, 2019
src/Tests/Microsoft.NET.Publish.Tests/NetCorePublishItemsOutputGroupTests.cs
Outdated
Show resolved
Hide resolved
peterhuene
reviewed
Apr 5, 2019
src/Tests/Microsoft.NET.Publish.Tests/NetCorePublishItemsOutputGroupTests.cs
Outdated
Show resolved
Hide resolved
MSLukeWest
changed the title
peterhuene
reviewed
Apr 6, 2019
src/Tests/Microsoft.NET.Publish.Tests/PublishItemsOutputGroupTests.cs
Outdated
Show resolved
Hide resolved
peterhuene
approved these changes
Apr 6, 2019
Contributor
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
With the fix for the test failure, I'm 👍 on this.
wli3
previously requested changes
Apr 7, 2019
wli3
left a comment
wli3
left a comment
There was a problem hiding this comment.
Hold until preview 4 branch merge is done. After noon Monday
Contributor
|
Btw i imagine this may be super useful for a lot of other project types.. i've been doing something similar as well. |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….20 (dotnet#3079) - Microsoft.DotNet.Cli.Runtime - 3.1.100-preview1.19504.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS installer projects need to be able to access an output group that contains publishing outputs in order to create MSIs for self contained deployment, so I'm adding PublishItemsOutputGroup to the publishing targets.