Code

Rewrite deps file generation#3086

Code

Merged

dsplaisted merged 41 commits intodotnet:release/3.0.1xxdotnet/sdk:release/3.0.1xxfrom dsplaisted:rewrite-deps-generationdsplaisted/sdk:rewrite-deps-generationCopy head branch name to clipboardApr 11, 2019

+1,589-75

Commits

Commits on Apr 9, 2019

• Add tests for passing FilesToSkip to GenerateDepsFile

  dsplaisted

  committed
  3b824b6

  Copy full SHA for 3b824b6

• Stop generating runtime signature for deps.json

  dsplaisted

  committed
  64acbcc

  Copy full SHA for 64acbcc

• Set package ID metadata on conflict items

  dsplaisted

  committed
  45bcfd4

  Copy full SHA for 45bcfd4

• Implement new deps file generation logic

  dsplaisted

  committed
  acc8b26

  Copy full SHA for acc8b26

• Write RuntimeIdentifier to RuntimeTargets items in ResolvePackageAssets

  dsplaisted

  committed
  76d7db9

  Copy full SHA for 76d7db9

• Use ResolvedFile class to pass resolved NuGet files to new deps file generation logic

  dsplaisted

  committed
  4a21bb0

  Copy full SHA for 4a21bb0

• Write RelativePath for resolved compile reference items in ResolvePackageAssets

  dsplaisted

  committed
  79a5043

  Copy full SHA for 79a5043

• More implementation of new deps file generation logic

  dsplaisted

  committed
  755536d

  Copy full SHA for 755536d

• Integrate new deps file generation logic into GenerateDepsFile task

  dsplaisted

  committed
  f740835

  Copy full SHA for f740835

• Use PathInPackage instead of RelativePath for item metadata

  dsplaisted

  committed
  fc6de74

  Copy full SHA for fc6de74

• Write deps files with both old and new methods, and ensure they are equivalent

  dsplaisted

  committed
  bcd5188

  Copy full SHA for bcd5188

• Fix dependency calculation in deps file generation

  Show description for 4b71244
  dsplaisted

  committed
  4b71244

  Copy full SHA for 4b71244

• Remove conflict files from items used by GenerateDepsFile

  dsplaisted

  committed
  916eb83

  Copy full SHA for 916eb83

• Include more metadata on output from ResolvePackageAssets even if it isn't copy local

  Show description for c7549ff
  dsplaisted

  committed
  c7549ff

  Copy full SHA for c7549ff

• Fix dictionary that wasn't case-insensitive, delete extra deps.json file if old and new versions matched

  dsplaisted

  committed
  d4637bd

  Copy full SHA for d4637bd

• Add property to control which version of deps generation is used

  dsplaisted

  committed
  7bb64cc

  Copy full SHA for 7bb64cc

• Use RID-less assets file target compilation assets when writing deps file

  Show description for cca7bfc
  dsplaisted

  committed
  cca7bfc

  Copy full SHA for cca7bfc

• Fix writing runtime pack libraries to deps.json

  dsplaisted

  committed
  4ef1d17

  Copy full SHA for 4ef1d17

• Don't create empty asset groups for deps.json if all files are trimmed

  Show description for db4dc8d
  dsplaisted

  committed
  db4dc8d

  Copy full SHA for db4dc8d

• Fix path for resources assets in deps.json

  dsplaisted

  committed
  6a1d766

  Copy full SHA for 6a1d766

• Filter conflict runtime pack assets from deps file

  dsplaisted

  committed
  f2ed7de

  Copy full SHA for f2ed7de

• Filter publish conflict packages from new deps file generation

  dsplaisted

  committed
  abd3f36

  Copy full SHA for abd3f36

• Fix deps library lookup to handle multitargeted projects depending on different library versions

  dsplaisted

  committed
  91d36a9

  Copy full SHA for 91d36a9

• Update tests that need new deps file generation mode

  dsplaisted

  committed
  bd10b02

  Copy full SHA for bd10b02

• Read PackageOverrides from targeting packs

  dsplaisted

  committed
  eb9afbb

  Copy full SHA for eb9afbb

• Don't rely on heuristic to find NuGet package ID for a file

  dsplaisted

  committed
  030137f

  Copy full SHA for 030137f

• Fix platform library calculation for ASP.NET Core apps

  Show description for fc31c03
  dsplaisted

  committed
  fc31c03

  Copy full SHA for fc31c03

• Fix resource skipping tests on non-Windows

  dsplaisted

  committed
  f353115

  Copy full SHA for f353115

• Match previous logic for what library dependencies are included in the deps file

  dsplaisted

  committed
  c7c062e

  Copy full SHA for c7c062e

• Don't use fluent assertions in product code to validate that deps files match

  dsplaisted

  committed
  e0ec4d0

  Copy full SHA for e0ec4d0

• Code review feedback

  dsplaisted

  committed
  b0ee865

  Copy full SHA for b0ee865

• Fix generating error about mismatching deps files

  dsplaisted

  committed
  b20aada

  Copy full SHA for b20aada

• Fix GenerateDepsFile task not returning failure when error is logged

  dsplaisted

  committed
  68e6297

  Copy full SHA for 68e6297

• Don't remove compile conflicts from runtime assets and vice versa for deps file generation

  dsplaisted

  committed
  7f3c8b7

  Copy full SHA for 7f3c8b7

• Use string comparison instead of parsing and comparing json

  dsplaisted

  committed
  ca946c4

  Copy full SHA for ca946c4

• Don't put runtime pack dependencies in the "compile" projects in deps.json

  dsplaisted

  committed
  adb4014

  Copy full SHA for adb4014

• Update deps file mismatch error text

  dsplaisted

  committed
  4754e44

  Copy full SHA for 4754e44

Commits on Apr 10, 2019

• Update stage 0

  dsplaisted

  committed
  a56fb4f

  Copy full SHA for a56fb4f

• Add System.Data.DataSetExtensions.dll to expected .NET Core 3 self-contained output

  dsplaisted

  committed
  c8f8b9d

  Copy full SHA for c8f8b9d

• Install 2.2.4 shared framework

  dsplaisted

  committed
  3ce6af5

  Copy full SHA for 3ce6af5

Commits on Apr 11, 2019

• Update perf test sources

  Show description for 9ead3df
  dsplaisted

  committed
  9ead3df

  Copy full SHA for 9ead3df