Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #31139

Merged
merged 11 commits into from
Mar 14, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 11, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20230313.5
  • Date Produced: March 13, 2023 9:54:45 PM UTC
  • Commit: e247ef3c03f5dae7ed634d83ec53e1386e5fe57d
  • Branch: refs/heads/main

…0310.7

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23160.7
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…0310.11

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23160.11
…0310.14

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23160.14
…0311.1

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23161.1
…0311.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23161.2
…0311.3

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23161.3
…0312.1

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23162.1
…0312.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23162.2
…0313.2

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23163.2
@jeffschwMSFT
Copy link
Member

rerunning

Unable to find package Microsoft.NETCore.App.Runtime.win-x86 with version (= 8.0.0-preview.3.23163.2)

@jeffschwMSFT
Copy link
Member

@dotnet/domestic-cat can you take a quick look? Looks related to warnings/errors for code analysis? Which team is best to look deeper?

@marcpopMSFT
Copy link
Member

marcpopMSFT commented Mar 13, 2023

@jaredpar is this one of those cases where the compiler in runtime needs to be updated?

        CSC : warning CS9057: The analyzer assembly 'C:\h\w\B39F09F6\t\dotnetSdkTests\jeghhhh5.5el\.nuget\packages\microsoft.netcore.app.ref\8.0.0-preview.3.23163.2\analyzers\dotnet\cs\Microsoft.Interop.JavaScript.JSImportGenerator.dll' references version '4.5.0.0' of the compiler, which is newer than the currently running version '4.4.0.0'. [C:\h\w\B39F09F6\t\dotnetSdkTests\jeghhhh5.5el\It_bulk_confi---A39AA6F6\HelloWorld\HelloWorld.csproj]
        CSC : warning CS9057: The analyzer assembly 'C:\h\w\B39F09F6\t\dotnetSdkTests\jeghhhh5.5el\.nuget\packages\microsoft.netcore.app.ref\8.0.0-preview.3.23163.2\analyzers\dotnet\cs\Microsoft.Interop.LibraryImportGenerator.dll' references version '4.5.0.0' of the compiler, which is newer than the currently running version '4.4.0.0'. [C:\h\w\B39F09F6\t\dotnetSdkTests\jeghhhh5.5el\It_bulk_confi---A39AA6F6\HelloWorld\HelloWorld.csproj]
        CSC : warning CS9057: The analyzer assembly 'C:\h\w\B39F09F6\t\dotnetSdkTests\jeghhhh5.5el\.nuget\packages\microsoft.netcore.app.ref\8.0.0-preview.3.23163.2\analyzers\dotnet\cs\System.Text.RegularExpressions.Generator.dll' references version '4.5.0.0' of the compiler, which is newer than the currently running version '4.4.0.0'. [C:\h\w\B39F09F6\t\dotnetSdkTests\jeghhhh5.5el\It_bulk_confi---A39AA6F6\HelloWorld\HelloWorld.csproj]

CC @nagilson @baronfel who've worked on this test.

@jaredpar
Copy link
Member

is this one of those cases where the compiler in runtime needs to be updated?

Yes.

@jeffschwMSFT
Copy link
Member

@agocke
Copy link
Member

agocke commented Mar 13, 2023

@jkoritzinsky Could you sync up the runtime version with the reference version?

@jkoritzinsky
Copy link
Member

This is a repeat of an issue we've hit previously:

The FullFramework test leg uses the LKG Roslyn that is older than the version in the "min version" in the SDK provided by Arcade in their global.json. In particular, the VS installation has Roslyn 4.4, probably because it is VS 17.4. We recently updated the version of Roslyn in dotnet/runtime in preparation for using new APIs that are available in Roslyn 4.5 based on the premise that everyone was using at least the Roslyn version defined in dotnet/arcade's referenced SDK (which is our general policy to avoid these kinds of breaks, which I guess isn't working particularly well).

This isn't a problem for the shipping product, as we'll have a matching Roslyn version to the SDK when we ship.

See #27406 for when this happened the last time. This time, we were able to modify the test to not fail when this scenario happens. I'll take a look at the test and see if we can figure out a good way to suppress this diagnostic while still testing what we want to test.

It looks like the 17.5 VS version is in the scouting queue. When that's pushed out to the regular queue, the failure will automatically go away, but I have no idea when that's going to be pushed out given the team restructurings.

@jkoritzinsky
Copy link
Member

I've pushed a change to the failing test to suppress this warning as it is unrelated to what is actually being tested. This is the same approach we took in #27406 to avoid having this issue come up every time we bump the Roslyn version the generators target.

…0313.5

Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.8.0 , VS.Redist.Common.NetCore.TargetingPack.x64.8.0
 From Version 8.0.0-preview.3.23160.6 -> To Version 8.0.0-preview.3.23163.5
@v-wuzhai v-wuzhai merged commit 3f4fd12 into main Mar 14, 2023
@v-wuzhai v-wuzhai deleted the darc-main-b8f1045f-210f-4411-aa69-a9cce0de975c branch March 14, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants