Couple of fixes and tweaks to the R2R creation logic #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing /Platform_Assemblies_Paths to a set of /r arguments Using resolved files list as assembly references to crossgen (temp hack until issue 3110 is fixed)
Author
|
@nguerrera PTAL |
1 similar comment
Author
|
@nguerrera PTAL |
nguerrera
suggested changes
Apr 15, 2019
Author
I don't really have a preference on where to put this. I was thinking it would be easier to fix this later by deleting a well defined piece of code rather than some scattered bits. It's just a matter of style really |
Contributor
OK, that's fine since this is just temporary until #3110 |
nguerrera
approved these changes
Apr 17, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…build 20191006.2 (dotnet#3121) - Microsoft.NET.Sdk.Razor - 3.1.0-preview1.19506.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing crossgen commands to use response files.
Changing /Platform_Assemblies_Paths to a set of /r arguments
Using resolved files list as assembly references to crossgen (temp hack until issue 3110 is fixed)