Allow disabling apphost #3136
Merged
Allow disabling apphost #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wli3
reviewed
Apr 18, 2019
|
|
||
| </ResolveFrameworkReferences> | ||
|
|
||
| <PropertyGroup Condition="'$(AppHostRuntimeIdentifier)' == '' And |
wli3
reviewed
Apr 18, 2019
| { | ||
| // NETSDK1084: There was no app host for available for the specified RuntimeIdentifier '{0}'. | ||
| Log.LogError(Strings.NoAppHostAvailable, runtimeIdentifier); | ||
| if (errorIfNotFound) |
There was a problem hiding this comment.
why this change?
In general i don't like a flag to not make error to message. It is like a flag to control throw or not.
wli3
approved these changes
Apr 18, 2019
|
@dsplaisted sorry for the delay |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…007.2 (dotnet#3136) - Microsoft.NET.Sdk.Web - 3.0.100-rc2.19507.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to find apphost packs if UseAppHost is not true.
There was a regression in global tool installation caught by the GivenDotnetInstallTool.ItRunsWithTheSpecifiedVerbosity test in the cli repo. This is a targeted change to enable fixing that (the dummy restore.proj will need to set UseAppHost to false too), in order to unblock dotnet/cli#11166.
This is related to #3135, but this PR is a more surgical fix than the broader questions in that bug.