9500 dotnet tool install: Add automatically tool upgrade and downgrade when specify version #31549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
…it-0 Conflicts: src/Cli/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallCommandParser.cs src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallLocalCommand.cs src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.cs.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.de.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.es.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.fr.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.it.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.ja.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.ko.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.pl.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.pt-BR.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.ru.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.tr.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.zh-Hans.xlf src/Cli/dotnet/commands/dotnet-tool/install/xlf/LocalizableStrings.zh-Hant.xlf src/Tests/dotnet.Tests/CommandTests/ToolInstallLocalCommandTests.cs
dsplaisted
reviewed
Apr 25, 2023
src/Cli/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallLocalCommand.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallLocalCommand.cs
Outdated
Show resolved
Hide resolved
| @@ -77,71 +77,29 @@ public override int Execute() | |||
| (FilePath? manifestFileOptional, string warningMessage) = | |||
There was a problem hiding this comment.
It looks like the only difference between this Execute method and the one for ToolInstallCommand is that this one may print a warning message. Can we add that to the ToolInstallCommand and then remove the duplication by having this one call that Execute method?
src/Tests/dotnet.Tests/CommandTests/ToolInstallLocalCommandTests.cs
Outdated
Show resolved
Hide resolved
JL03-Yue
requested review from
a team,
andriipatsula,
ericstj,
joperezr,
tmat,
arunchndr,
AntonLapounov and
sharwell
as code owners
|
Reopened at #35088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9500
Update
dotnet tool installso that it support automatic upgrade, downgrade, and error-throwing behaviors.--allow-downgradeflag and version 4.0.0 is installed, it throws out an error.--allow-downgradeflag and version 4.0.0 is installed, downgrade to 3.0.0. Exit code = 0