ILLink cleanup #3156
Merged
ILLink cleanup #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the default as of dotnet#3152
- Change name to singular version - Remove property with the same name - Update tests to use the ItemGroup instead
The default is to copy used assemblies. Also disable mono-specific localization assembly behavior (-l none). These defaults more properly belong in ILLink.Tasks, but I'd like to set them here for this preview to avoid having to wait for changes to flow through again.
swaroop-sridhar
approved these changes
Apr 22, 2019
|
@nguerrera PTAL |
nguerrera
approved these changes
Apr 29, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….7 (dotnet#3156) - Microsoft.NET.Sdk - 3.0.101-servicing.19510.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respond to remaining feedback from #3125:
TrimmerRootDescriptor(singular) itemgroup, without a corresponding property@swaroop-sridhar The second two commits set the proper linker defaults. I made them part of the same PR to avoid having to fix merge conflicts between these changes.