Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to #31559 #32047

Merged
merged 3 commits into from
May 8, 2023
Merged

Follow-up to #31559 #32047

merged 3 commits into from
May 8, 2023

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Apr 25, 2023 •
edited
Loading

Addresses some follow-up items from #31559:

  • Skip the BrotliCompress task if there are no files to compress
  • Remove references to the targets AssignRazorComponentTargetPaths and AssignRazorGenerateTargetPaths from the StaticWebAssets SDK
  • Remove _StaticWebAssetsSdkRazorToolAssembly from the StaticWebAssets SDK

Fixes dotnet/aspnetcore#47374
Fixes #32004

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Apr 25, 2023
@MackinnonBuck MackinnonBuck added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Thanks for your PR, @MackinnonBuck.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@MackinnonBuck MackinnonBuck removed untriaged Request triage from a team member Area-NetSDK labels Apr 25, 2023
@MackinnonBuck MackinnonBuck force-pushed the mbuck/31559-follow-up branch from 0d9a468 to a3790af Compare April 26, 2023 22:28
MackinnonBuck
MackinnonBuck commented Apr 26, 2023
View reviewed changes
src/StaticWebAssetsSdk/Tasks/RewriteCss.cs
public int DeleteLength { get; set; }
}

private class SourceFile
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this class to provide a helper for extracting line/column numbers from @import uses. We could definitely remove this if we're okay with not having line numbers in error messages. If we do that, we'll probably want to deduplicate error messages that relate to the same file.

@MackinnonBuck MackinnonBuck marked this pull request as ready for review April 26, 2023 22:32
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner April 26, 2023 22:32
@MackinnonBuck MackinnonBuck requested a review from javiercn April 27, 2023 15:56
javiercn
javiercn approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MackinnonBuck MackinnonBuck merged commit 9314a55 into main May 8, 2023
@MackinnonBuck MackinnonBuck deleted the mbuck/31559-follow-up branch May 8, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build performance regression Remove Razor SDK dependency in StaticWebAssets SDK
2 participants
@MackinnonBuck @javiercn