Fix packasktool cannot run #3212
Conversation
wli3
changed the title
wli3
changed the title
| </ItemGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <UseAppHost Condition=" '$(SelfContained)' != 'true' and '$(PackAsTool)' == 'true' ">false</UseAppHost> |
There was a problem hiding this comment.
This is tricky. I don't have a good solution:
This line need to be inside a target. Since PackAsTool is set in csproj.
And it need to be before Microsoft.NET.Sdk.targets (basically command target), so "RunCommand" property can use the correct value.
I try to keep PackAsTool logic in one place. But I cannot in this case. So far that's where I think is the best
There was a problem hiding this comment.
I think the second best place to put this would be where we decide the AppHost default:
In the same way that ideally these targets wouldn't know about PackAsTool, you can almost argue that PackAsTool shouldn't need to know about above. We either keep PackAsTool with PackAsTool or UseAppHost with UseAppHost. And only the latter actually works. ;)
There was a problem hiding this comment.
I'd second that. I think we can work this logic into the place we default UseAppHost.
It needs to be inside a target. Since PackAsTool is set in csproj. And it need to be before Microsoft.NET.Sdk.targets (basically command target), so "RunCommand" property can use the correct value.
wli3
changed the title
|
Edited according to the discussion. this is good to review now |
…build 20191017.5 (dotnet#3212) - Microsoft.NET.Sdk.Razor - 3.0.1
3 participants
No description provided.