Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Own build] Don't use AssemblyInformationCachePaths #32355

Merged
merged 1 commit into from
May 10, 2023

Conversation

ladipro
Copy link
Member

@ladipro ladipro commented May 9, 2023

Now that dotnet/msbuild#8688 is in, we no longer get value from the SDK pre-cache. The cost of reading the cache is >50 ms per project, which typically makes it the most expensive part of RAR.

Trace from MSBuild command line build:

image

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label May 9, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ladipro
Copy link
Member Author

ladipro commented May 10, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ladipro ladipro merged commit fb01b69 into dotnet:main May 10, 2023
@ladipro ladipro deleted the disable-precache branch May 10, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants