Support Records in GenAPI #34433
Merged
Support Records in GenAPI #34433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class records are mostly handled and regenerated with minimal compiler boilerplate. �Struct records show all the compiler generated boilerplate as I don't try to discern them from regular structs. We could do more here - by recognizing all the compiler generated members and reducing, but it's not necessary for compat parity.
ericstj
requested review from
andriipatsula,
a team and
joperezr
as code owners
dotnet-issue-labeler
bot
added
Area-GenAPI
untriaged
carlossanlop
approved these changes
Aug 3, 2023
src/Tests/Microsoft.DotNet.GenAPI.Tests/CSharpFileBuilderTests.cs
Outdated
Show resolved
Hide resolved
src/ApiCompat/Microsoft.DotNet.ApiCompatibility/Microsoft.DotNet.ApiCompatibility.csproj
Show resolved
Hide resolved
ViktorHofer
reviewed
Aug 3, 2023
ViktorHofer
reviewed
Aug 3, 2023
ViktorHofer
approved these changes
Aug 5, 2023
|
Looks like I broke things a bit when moving to the filter. Fixing ... |
ViktorHofer
approved these changes
Aug 10, 2023
|
If we wanted to better handle struct records we could implement our own heuristic for detecting them from metadata - essentially if we see the entire set of methods that could be replaced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32196
Class records are mostly handled and regenerated with minimal compiler boilerplate.
Struct records show all the compiler generated boilerplate as I don't try to discern them from regular structs. We could do more here - by recognizing all the compiler generated members and reducing, but it's not necessary for compat parity.