Create project templates target to 9.0

[v-wuzhai]

No description provided.

[v-wuzhai]

@MiYanni We still have to update dotnet sdk to 9.0 judging from these test failures.

• Update the sdk target to net9.0: Update the sdk target to net9.0 #35031

[MiYanni]

@MiYanni We still have to update dotnet sdk to 9.0 judging from these test failures.

I'm not sure of the order of updates that need to occur. I'm new to the team and haven't been around for a major version rebranding before. Jacques or Daniel might have a better grasp on it.

[marcpopMSFT]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[v-wuzhai]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[v-wuzhai]

@baronfel @marcpopMSFT There are some container test failures like this:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

Could you help to take a look?

[baronfel]

These specific container tests are in an awkward position: They rely on dotnet/runtime-deps, dotnet/runtime, dotnet/aspnet base images being available with .NET and ASP.NET Runtimes matching the one being targeted for (which don't exist yet), and so they deliberately pin to versions behind the latest. We need a better story here for testing changes, but there aren't currently any SDK Container tooling features that are reliant on .NET 9, so we could probably just keep these tests pinned to .Net 8 (where we do have usable base images) and bump them to 9 at a later time, once we begin creating usable .NET 9 images from dotnet/dotnet-docker.

[marcpopMSFT]

FYI, I'm waiting for main codeflow into installer to get unblocked before reviewing and approving.

[kasperk81]

@marcpopMSFT codeflow is unblobked

[marcpopMSFT]

@v-wuzhai thank you for putting this together. It looks pretty good to me. I left a few comments. The biggest one is around the localization of Target. It looks like when Vlada did the 8 migration, she just changed everything back to english and then let the translators swap it back in a future onelocbuild.

So it sounds like it might be safe to leave as is but it also seems like it would save the translators time if we just left the translation as is. @baronfel @YuliiaKovalova do ya'll know why Vlada chose to swap the localized json files to have english (is there tooling that generates those and so they switched automatically?)

[YuliiaKovalova]

@v-wuzhai thank you for putting this together. It looks pretty good to me. I left a few comments. The biggest one is around the localization of Target. It looks like when Vlada did the 8 migration, she just changed everything back to english and then let the translators swap it back in a future onelocbuild.

So it sounds like it might be safe to leave as is but it also seems like it would save the translators time if we just left the translation as is. @baronfel @YuliiaKovalova do ya'll know why Vlada chose to swap the localized json files to have english (is there tooling that generates those and so they switched automatically?)

I have no idea here.
When I created item templates last year, I didn't swap anything - just committed the created templates with the localization files (https://github.com/dotnet/sdk/pull/29655/files#diff-cf06339338d8bb65d704739d4f01f726d7676c2102729696a1e01e3a1cfbeb76) and later it was translated by a dedicated tool in a separate PR YuliiaKovalova@693354e

[marcpopMSFT]

So if we switched back to the loc templates, that'd be fine and it also might be fine to leave as is (as it'll get updated later)?

[v-wuzhai]

So if we switched back to the loc templates, that'd be fine and it also might be fine to leave as is (as it'll get updated later)?

Looks like there will be an update to these localized files later.
b486772

[marcpopMSFT]

I think the drawback is that it won't get fixed until we create a 9.0.1xx branch and target localization at that branch (so templates will be unlocalized until August). @baronfel thoughts on whether we should have Jason go fix all the localization now or just let it get fixed in normal flow in August?

[kasperk81]

you can revert the word "Target" in localization files on linux in no time:

git checkout Jason/UpdateTemplates
git checkout origin/main ':/*templatestrings*json'
git reset
git ls-files ':/*templatestrings*json' | xargs sed -i'' 's/net8/net9/g'

commit and push

[YuliiaKovalova]

So if we switched back to the loc templates, that'd be fine and it also might be fine to leave as is (as it'll get updated later)?

Yes, I think so.

[marcpopMSFT]

@kasperk81 thanks for catching that and the tip on reverting it. @v-wuzhai thanks for updating the PR to include that. It looks good to me now.

@baronfel @MiYanni @joeloff any concerns before we merge this?

[baronfel]

Nope! Let's get this thing rolling!

[kasperk81]

i tried latest build sdk: 9.0.100-alpha.1.23531.19 with installer 9.0.100-alpha.1.23531.19

dotnet new console -f net9.0 -o test
Error: Invalid option(s):
-f net9.0
   'net9.0' is not a valid value for -f. The possible values are:
      net8.0   - Target net8.0

what is still missing to complete this transition?

[kasperk81]

needed dotnet/installer#17684 installer: 9.0.100-alpha.1.23551.16 supports -f net9.0. thanks @marcpopMSFT!