Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the sdk target to net9.0 #35031

Merged
merged 21 commits into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
271345c
Update the sdk target to net9.0
v-wuzhai Aug 30, 2023
bbae7f7
Merge branch 'main' of https://github.com/dotnet/sdk into Jason/Updat…
v-wuzhai Sep 20, 2023
1cd7fa7
Update the stage 0 SDK
marcpopMSFT Oct 5, 2023
1587e8d
Fix templating tests for removal of blazorwasm empty template
marcpopMSFT Oct 5, 2023
b78dd63
update hardcoded TFM references in container task loading and package…
baronfel Oct 5, 2023
eff033f
use Toolsetinfo in container tests to be future proof
baronfel Oct 5, 2023
94b5314
Fix illink expected warnings for net9.0
sbomer Oct 6, 2023
497e8f5
Fix preview test and more templating tests
marcpopMSFT Oct 6, 2023
eacd32d
Fix some additional tests for the new TFM
marcpopMSFT Oct 6, 2023
fe328c3
Merge branch 'main' of https://github.com/dotnet/sdk into Jason/Updat…
v-wuzhai Oct 7, 2023
8c87367
Re-generate the baselines
v-wuzhai Oct 8, 2023
20c549f
Updated the baselines and fixed more of test failures
v-wuzhai Oct 8, 2023
0e79934
Add the rc2 runtime that's expected in the aspnet test assemblies
marcpopMSFT Oct 9, 2023
97d8ea0
Updating the runtime in the restore toolset script didn't help so ena…
marcpopMSFT Oct 10, 2023
37ab887
Updating to a newer installer build with the compiler IL fix
marcpopMSFT Oct 10, 2023
ae132a9
Gather more details when the symbol file isn't present to help debug
marcpopMSFT Oct 11, 2023
8e4195b
Update to installer build with fixed webassembly pack
marcpopMSFT Oct 11, 2023
7acdc2f
Update the blazor baselines
marcpopMSFT Oct 11, 2023
7e7449e
Update the prebuilt exclusion list for the 8.0 targeting packs for now
marcpopMSFT Oct 11, 2023
06c0a6a
Disable three failing tests on mac per Sven that need an installer pa…
marcpopMSFT Oct 11, 2023
f894658
remove errant comma
marcpopMSFT Oct 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<!-- Default to all packages generating a corresponding symbol package -->
<IncludeSymbols>true</IncludeSymbols>
<IsShippingPackage>false</IsShippingPackage>
<SdkTargetFramework>net8.0</SdkTargetFramework>
<SdkTargetFramework>net9.0</SdkTargetFramework>
<!-- Temporarily disable build warnings while upgrading to the net9.0 TFM -->
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
<ToolsetTargetFramework>$(SdkTargetFramework)</ToolsetTargetFramework>
Expand Down
2 changes: 2 additions & 0 deletions build/RunTestsOnHelix.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ set DOTNET_ROOT=%HELIX_CORRELATION_PAYLOAD%\d
set PATH=%DOTNET_ROOT%;%PATH%
set DOTNET_MULTILEVEL_LOOKUP=0
set TestFullMSBuild=%1
set DOTNET_ROLL_FORWARD=Major
set DOTNET_ROLL_FORWARD_TO_PRERELEASE=1

set TestExecutionDirectory=%CD%\testExecutionDirectory
mkdir %TestExecutionDirectory%
Expand Down
3 changes: 3 additions & 0 deletions build/RunTestsOnHelix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ export DOTNET_SDK_TEST_EXECUTION_DIRECTORY=$TestExecutionDirectory
export DOTNET_SDK_TEST_MSBUILDSDKRESOLVER_FOLDER=$HELIX_CORRELATION_PAYLOAD/r
export DOTNET_SDK_TEST_ASSETS_DIRECTORY=$TestExecutionDirectory/Assets

export DOTNET_ROLL_FORWARD=Major
export DOTNET_ROLL_FORWARD_TO_PRERELEASE=1

# call dotnet new so the first run message doesn't interfere with the first test
dotnet new --debug:ephemeral-hive

Expand Down
4 changes: 4 additions & 0 deletions eng/SourceBuildPrebuiltBaseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,9 @@
<UsagePattern IdentityGlob="Microsoft.NET.HostModel/*8.0.0*" />
<UsagePattern IdentityGlob="Microsoft.Extensions.DependencyModel/*8.0.0*" />
<UsagePattern IdentityGlob="Microsoft.Bcl.AsyncInterfaces/*8.0.0*" />

<!-- in trying to unblock main, we have an older 8.0 ref pack for the moment -->
<UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/*8.0.0*" />
<UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/*8.0.0*" />
</IgnorePatterns>
</UsageData>
2 changes: 2 additions & 0 deletions eng/restore-toolset.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ function InitializeCustomSDKToolset {
InstallDotNetSharedFramework "5.0.0"
InstallDotNetSharedFramework "6.0.0"
InstallDotNetSharedFramework "7.0.0"
InstallDotNetSharedFramework "8.0.0-preview.7.23375.6"
InstallDotNetSharedFramework "8.0.0-rc.2.23457.7"

CreateBuildEnvScripts
CreateVSShortcut
Expand Down
2 changes: 2 additions & 0 deletions eng/restore-toolset.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ function InitializeCustomSDKToolset {
InstallDotNetSharedFramework "5.0.0"
InstallDotNetSharedFramework "6.0.0"
InstallDotNetSharedFramework "7.0.0"
InstallDotNetSharedFramework "8.0.0-preview.7.23375.6"
InstallDotNetSharedFramework "8.0.0-rc.2.23457.7"

CreateBuildEnvScript
}
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"tools": {
"dotnet": "9.0.100-alpha.1.23421.9",
"dotnet": "9.0.100-alpha.1.23511.2",
"runtimes": {
"dotnet": [
"$(VSRedistCommonNetCoreSharedFrameworkx6490PackageVersion)"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">
<PropertyGroup>
<AddRazorSupportForMvc>true</AddRazorSupportForMvc>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<Copyright>© Microsoft</Copyright>
<Product>Razor Test</Product>
<Company>Microsoft</Company>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<AddRazorSupportForMvc>true</AddRazorSupportForMvc>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<Copyright>© Microsoft</Copyright>
<Product>Razor Test</Product>
<Company>Microsoft</Company>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<AddRazorSupportForMvc>true</AddRazorSupportForMvc>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<Copyright>© Microsoft</Copyright>
<Product>Razor Test</Product>
<Company>Microsoft</Company>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<AddRazorSupportForMvc>true</AddRazorSupportForMvc>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<Copyright>© Microsoft</Copyright>
<Product>Razor Test</Product>
<Company>Microsoft</Company>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ Copyright (c) .NET Foundation. All rights reserved.
<PropertyGroup>
<!-- Paths to tools, tasks, and extensions are calculated relative to the BlazorWebAssemblySdkDirectoryRoot. This can be modified to test a local build. -->
<BlazorWebAssemblySdkDirectoryRoot Condition="'$(BlazorWebAssemblySdkDirectoryRoot)'==''">$(MSBuildThisFileDirectory)..\</BlazorWebAssemblySdkDirectoryRoot>
<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net8.0</_BlazorWebAssemblySdkTasksTFM>
<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net9.0</_BlazorWebAssemblySdkTasksTFM>
<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' != 'Core'">net472</_BlazorWebAssemblySdkTasksTFM>
<_BlazorWebAssemblySdkTasksAssembly>$(BlazorWebAssemblySdkDirectoryRoot)tools\$(_BlazorWebAssemblySdkTasksTFM)\Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.dll</_BlazorWebAssemblySdkTasksAssembly>
<_BlazorWebAssemblySdkToolAssembly>$(BlazorWebAssemblySdkDirectoryRoot)tools\net8.0\Microsoft.NET.Sdk.BlazorWebAssembly.Tool.dll</_BlazorWebAssemblySdkToolAssembly>
<_BlazorWebAssemblySdkToolAssembly>$(BlazorWebAssemblySdkDirectoryRoot)tools\net9.0\Microsoft.NET.Sdk.BlazorWebAssembly.Tool.dll</_BlazorWebAssemblySdkToolAssembly>
</PropertyGroup>

<UsingTask TaskName="Microsoft.NET.Sdk.BlazorWebAssembly.GenerateBlazorWebAssemblyBootJson50" AssemblyFile="$(_BlazorWebAssemblySdkTasksAssembly)" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ Copyright (c) .NET Foundation. All rights reserved.
<PropertyGroup>
<!-- Paths to tools, tasks, and extensions are calculated relative to the BlazorWebAssemblySdkDirectoryRoot. This can be modified to test a local build. -->
<BlazorWebAssemblySdkDirectoryRoot Condition="'$(BlazorWebAssemblySdkDirectoryRoot)'==''">$(MSBuildThisFileDirectory)..\</BlazorWebAssemblySdkDirectoryRoot>
<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net8.0</_BlazorWebAssemblySdkTasksTFM>
<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net9.0</_BlazorWebAssemblySdkTasksTFM>
<_BlazorWebAssemblySdkTasksTFM Condition=" '$(MSBuildRuntimeType)' != 'Core'">net472</_BlazorWebAssemblySdkTasksTFM>
<_BlazorWebAssemblySdkTasksAssembly>$(BlazorWebAssemblySdkDirectoryRoot)tools\$(_BlazorWebAssemblySdkTasksTFM)\Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.dll</_BlazorWebAssemblySdkTasksAssembly>
<_BlazorWebAssemblySdkToolAssembly>$(BlazorWebAssemblySdkDirectoryRoot)tools\net8.0\Microsoft.NET.Sdk.BlazorWebAssembly.Tool.dll</_BlazorWebAssemblySdkToolAssembly>
<_BlazorWebAssemblySdkToolAssembly>$(BlazorWebAssemblySdkDirectoryRoot)tools\net9.0\Microsoft.NET.Sdk.BlazorWebAssembly.Tool.dll</_BlazorWebAssemblySdkToolAssembly>
</PropertyGroup>

<UsingTask TaskName="Microsoft.NET.Sdk.BlazorWebAssembly.CreateBlazorTrimmerRootDescriptorFile" AssemblyFile="$(_BlazorWebAssemblySdkTasksAssembly)" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<!-- A flag representing this package existing in a project. -->
<SDKContainerSupportEnabled>true</SDKContainerSupportEnabled>
<ContainerTaskFolderName>tasks</ContainerTaskFolderName>
<ContainerTaskFramework Condition="'$(MSBuildRuntimeType)' == 'Core'">net8.0</ContainerTaskFramework>
<ContainerTaskFramework Condition="'$(MSBuildRuntimeType)' == 'Core'">net9.0</ContainerTaskFramework>
<ContainerTaskFramework Condition="'$(MSBuildRuntimeType)' == 'Full'">net472</ContainerTaskFramework>
<ContainerizeFolderName>containerize</ContainerizeFolderName>
<!--The folder where the custom task will be present. It points to inside the nuget package. -->
Expand Down
2 changes: 1 addition & 1 deletion src/RazorSdk/Targets/Sdk.Razor.CurrentVersion.targets
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Copyright (c) .NET Foundation. All rights reserved.
<!-- Paths to tools, tasks, and extensions are calculated relative to the RazorSdkDirectoryRoot. This can be modified to test a local build. -->
<RazorSdkDirectoryRoot Condition="'$(RazorSdkDirectoryRoot)'==''">$(MSBuildThisFileDirectory)..\</RazorSdkDirectoryRoot>
<RazorSdkBuildTasksDirectoryRoot Condition="'$(RazorSdkBuildTasksDirectoryRoot)'==''">$(RazorSdkDirectoryRoot)tasks\</RazorSdkBuildTasksDirectoryRoot>
<_RazorSdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net8.0</_RazorSdkTasksTFM>
<_RazorSdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net9.0</_RazorSdkTasksTFM>
<_RazorSdkTasksTFM Condition=" '$(_RazorSdkTasksTFM)' == ''">net472</_RazorSdkTasksTFM>
<RazorSdkBuildTasksAssembly>$(RazorSdkBuildTasksDirectoryRoot)$(_RazorSdkTasksTFM)\Microsoft.NET.Sdk.Razor.Tasks.dll</RazorSdkBuildTasksAssembly>
<_RazorSdkToolAssembly>$(RazorSdkDirectoryRoot)tools\rzc.dll</_RazorSdkToolAssembly>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ Copyright (c) .NET Foundation. All rights reserved.
<!-- Paths to tools, tasks, and extensions are calculated relative to the StaticWebAssetsSdkDirectoryRoot. This can be modified to test a local build. -->
<StaticWebAssetsSdkDirectoryRoot Condition="'$(StaticWebAssetsSdkDirectoryRoot)'==''">$(MSBuildThisFileDirectory)..\</StaticWebAssetsSdkDirectoryRoot>
<StaticWebAssetsSdkBuildTasksDirectoryRoot Condition="'$(StaticWebAssetsSdkBuildTasksDirectoryRoot)'==''">$(StaticWebAssetsSdkDirectoryRoot)tasks\</StaticWebAssetsSdkBuildTasksDirectoryRoot>
<_StaticWebAssetsSdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net8.0</_StaticWebAssetsSdkTasksTFM>
<_StaticWebAssetsSdkTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net9.0</_StaticWebAssetsSdkTasksTFM>
<_StaticWebAssetsSdkTasksTFM Condition=" '$(_StaticWebAssetsSdkTasksTFM)' == ''">net472</_StaticWebAssetsSdkTasksTFM>
<StaticWebAssetsSdkBuildTasksAssembly>$(StaticWebAssetsSdkBuildTasksDirectoryRoot)$(_StaticWebAssetsSdkTasksTFM)\Microsoft.NET.Sdk.StaticWebAssets.Tasks.dll</StaticWebAssetsSdkBuildTasksAssembly>
<_StaticWebAssetsSdkToolAssembly>$(StaticWebAssetsSdkDirectoryRoot)tools\net8.0\Microsoft.NET.Sdk.StaticWebAssets.Tool.dll</_StaticWebAssetsSdkToolAssembly>
<_StaticWebAssetsSdkToolAssembly>$(StaticWebAssetsSdkDirectoryRoot)tools\net9.0\Microsoft.NET.Sdk.StaticWebAssets.Tool.dll</_StaticWebAssetsSdkToolAssembly>
</PropertyGroup>

<PropertyGroup Condition="'$(DOTNET_HOST_PATH)' == ''">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Copyright (c) .NET Foundation. All rights reserved.
<PropertyGroup>
<_TargetFrameworkVersionWithoutV>$(TargetFrameworkVersion.TrimStart('vV'))</_TargetFrameworkVersionWithoutV>

<MicrosoftNETBuildExtensionsTasksAssembly Condition="'$(MicrosoftNETBuildExtensionsTasksAssembly)' == '' AND '$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)\tools\net8.0\Microsoft.NET.Build.Extensions.Tasks.dll</MicrosoftNETBuildExtensionsTasksAssembly>
<MicrosoftNETBuildExtensionsTasksAssembly Condition="'$(MicrosoftNETBuildExtensionsTasksAssembly)' == '' AND '$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)\tools\net9.0\Microsoft.NET.Build.Extensions.Tasks.dll</MicrosoftNETBuildExtensionsTasksAssembly>
<MicrosoftNETBuildExtensionsTasksAssembly Condition="'$(MicrosoftNETBuildExtensionsTasksAssembly)' == ''">$(MSBuildThisFileDirectory)\tools\net472\Microsoft.NET.Build.Extensions.Tasks.dll</MicrosoftNETBuildExtensionsTasksAssembly>

<!-- Include conflict resolution targets for NETFramework and allow other frameworks to opt-in -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Copyright (c) .NET Foundation. All rights reserved.
<Project>
<PropertyGroup Condition="'$(UseApiCompatPackage)' != 'true'">
<DotNetApiCompatTaskAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)..\tools\net472\Microsoft.DotNet.ApiCompat.Task.dll</DotNetApiCompatTaskAssembly>
<DotNetApiCompatTaskAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)..\tools\net8.0\Microsoft.DotNet.ApiCompat.Task.dll</DotNetApiCompatTaskAssembly>
<DotNetApiCompatTaskAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)..\tools\net9.0\Microsoft.DotNet.ApiCompat.Task.dll</DotNetApiCompatTaskAssembly>
</PropertyGroup>

<ItemGroup Condition="'$(EnablePackageValidation)' == 'true' and
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Copyright (c) .NET Foundation. All rights reserved.

<PropertyGroup>
<MicrosoftNETBuildTasksDirectoryRoot>$(MSBuildThisFileDirectory)..\tools\</MicrosoftNETBuildTasksDirectoryRoot>
<MicrosoftNETBuildTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net8.0</MicrosoftNETBuildTasksTFM>
<MicrosoftNETBuildTasksTFM Condition=" '$(MSBuildRuntimeType)' == 'Core'">net9.0</MicrosoftNETBuildTasksTFM>
<MicrosoftNETBuildTasksTFM Condition=" '$(MicrosoftNETBuildTasksTFM)' == ''">net472</MicrosoftNETBuildTasksTFM>
<MicrosoftNETBuildTasksDirectory>$(MicrosoftNETBuildTasksDirectoryRoot)$(MicrosoftNETBuildTasksTFM)\</MicrosoftNETBuildTasksDirectory>
<MicrosoftNETBuildTasksAssembly>$(MicrosoftNETBuildTasksDirectory)Microsoft.NET.Build.Tasks.dll</MicrosoftNETBuildTasksAssembly>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ Copyright (c) .NET Foundation. All rights reserved.
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v7.0" DisplayName=".NET 7.0" Alias="net7.0" />
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v8.0" DisplayName=".NET 8.0" Alias="net8.0"
Condition="$([MSBuild]::VersionGreaterThanOrEquals($(MSBuildVersion), '17.8.0'))"/>
<SupportedNETCoreAppTargetFramework Include=".NETCoreApp,Version=v9.0" DisplayName=".NET 9.0" Alias="net9.0" />
</ItemGroup>

<PropertyGroup>
<UnsupportedTargetFrameworkVersion>9.0</UnsupportedTargetFrameworkVersion>
<MinimumVisualStudioVersionForUnsupportedTargetFrameworkVersion>17.8</MinimumVisualStudioVersionForUnsupportedTargetFrameworkVersion>
<UnsupportedTargetFrameworkVersion>10.0</UnsupportedTargetFrameworkVersion>
<MinimumVisualStudioVersionForUnsupportedTargetFrameworkVersion>17.12</MinimumVisualStudioVersionForUnsupportedTargetFrameworkVersion>
</PropertyGroup>

<!-- .NET Standard -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public void SanityTest_NET_Build_ContainersDependencies()
public void PackageContentTest()
{
string ignoredZipFileEntriesPrefix = "package/services/metadata";

var netTFM = ToolsetInfo.NextTargetFramework;
IReadOnlyList<string> packageContents = new List<string>()
{
"_rels/.rels",
Expand Down Expand Up @@ -124,28 +124,28 @@ public void PackageContentTest()
"tasks/net472/NuGet.ProjectModel.dll",
"tasks/net472/NuGet.Protocol.dll",
"tasks/net472/NuGet.Versioning.dll",
"tasks/net8.0/Microsoft.DotNet.Cli.Utils.dll",
"tasks/net8.0/Microsoft.Extensions.DependencyInjection.Abstractions.dll",
"tasks/net8.0/Microsoft.Extensions.DependencyInjection.dll",
"tasks/net8.0/Microsoft.Extensions.DependencyModel.dll",
"tasks/net8.0/Microsoft.Extensions.Logging.Abstractions.dll",
"tasks/net8.0/Microsoft.Extensions.Logging.dll",
"tasks/net8.0/Microsoft.Extensions.Options.dll",
"tasks/net8.0/Microsoft.Extensions.Primitives.dll",
"tasks/net8.0/Microsoft.NET.Build.Containers.deps.json",
"tasks/net8.0/Microsoft.NET.Build.Containers.dll",
"tasks/net8.0/Newtonsoft.Json.dll",
"tasks/net8.0/NuGet.Common.dll",
"tasks/net8.0/NuGet.Configuration.dll",
"tasks/net8.0/NuGet.DependencyResolver.Core.dll",
"tasks/net8.0/NuGet.Frameworks.dll",
"tasks/net8.0/NuGet.LibraryModel.dll",
"tasks/net8.0/NuGet.Packaging.dll",
"tasks/net8.0/NuGet.Packaging.Core.dll",
"tasks/net8.0/NuGet.ProjectModel.dll",
"tasks/net8.0/NuGet.Protocol.dll",
"tasks/net8.0/NuGet.Versioning.dll",
"tasks/net8.0/Valleysoft.DockerCredsProvider.dll"
$"tasks/{netTFM}/Microsoft.DotNet.Cli.Utils.dll",
$"tasks/{netTFM}/Microsoft.Extensions.DependencyInjection.Abstractions.dll",
$"tasks/{netTFM}/Microsoft.Extensions.DependencyInjection.dll",
$"tasks/{netTFM}/Microsoft.Extensions.DependencyModel.dll",
$"tasks/{netTFM}/Microsoft.Extensions.Logging.Abstractions.dll",
$"tasks/{netTFM}/Microsoft.Extensions.Logging.dll",
$"tasks/{netTFM}/Microsoft.Extensions.Options.dll",
$"tasks/{netTFM}/Microsoft.Extensions.Primitives.dll",
$"tasks/{netTFM}/Microsoft.NET.Build.Containers.deps.json",
$"tasks/{netTFM}/Microsoft.NET.Build.Containers.dll",
$"tasks/{netTFM}/Newtonsoft.Json.dll",
$"tasks/{netTFM}/NuGet.Common.dll",
$"tasks/{netTFM}/NuGet.Configuration.dll",
$"tasks/{netTFM}/NuGet.DependencyResolver.Core.dll",
$"tasks/{netTFM}/NuGet.Frameworks.dll",
$"tasks/{netTFM}/NuGet.LibraryModel.dll",
$"tasks/{netTFM}/NuGet.Packaging.dll",
$"tasks/{netTFM}/NuGet.Packaging.Core.dll",
$"tasks/{netTFM}/NuGet.ProjectModel.dll",
$"tasks/{netTFM}/NuGet.Protocol.dll",
$"tasks/{netTFM}/NuGet.Versioning.dll",
$"tasks/{netTFM}/Valleysoft.DockerCredsProvider.dll"
};

(string packageFilePath, string packageVersion) = ToolsetUtils.GetContainersPackagePath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public void TheMaximumVersionsAreSupported(string targetFrameworkIdentifier)
var project = new TestProject
{
Name = "packagethatwillgomissing",
TargetFrameworks = targetFrameworkIdentifier == ".NETCoreApp" ? ToolsetInfo.CurrentTargetFramework : "netstandard2.1",
TargetFrameworks = targetFrameworkIdentifier == ".NETCoreApp" ? ToolsetInfo.NextTargetFramework : "netstandard2.1",
};

TestAsset asset = _testAssetsManager
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,9 @@ public void It_includes_internals_visible_to()

[RequiresMSBuildVersionTheory("17.0.0.32901")]
[InlineData(true, true, "net5.0")]
[InlineData(true, true, ToolsetInfo.CurrentTargetFramework)]
[InlineData(true, false, ToolsetInfo.CurrentTargetFramework)]
[InlineData(false, false, ToolsetInfo.CurrentTargetFramework)]
[InlineData(true, true, ToolsetInfo.NextTargetFramework)]
[InlineData(true, false, ToolsetInfo.NextTargetFramework)]
[InlineData(false, false, ToolsetInfo.NextTargetFramework)]
public void TestPreviewFeatures(bool enablePreviewFeatures, bool generateRequiresPreviewFeaturesAttribute, string targetFramework)
{
var testAsset = _testAssetsManager
Expand Down Expand Up @@ -410,7 +410,7 @@ public void TestPreviewFeatures(bool enablePreviewFeatures, bool generateRequire

if (enablePreviewFeatures && generateRequiresPreviewFeaturesAttribute)
{
if (targetFramework == ToolsetInfo.CurrentTargetFramework)
if (targetFramework == ToolsetInfo.NextTargetFramework)
{
Assert.Equal("Preview", langVersion);
Assert.True(contains);
Expand Down
Loading