Add dotnet package search

[Nigusu-Allehu]

Fixes: NuGet/Home#6060

Description

• add a new command dotnet package search

• The spec of the new command is found here : Spec for dotnet package search : implements a search functionality. NuGet/Home#12886

• Here is the nuget.client side : Add dotnet package search  NuGet/NuGet.Client#5466

• Here is what a dotnet package search nuget would look like

[danmoseley]

Will this do all that Nuget.exe list does? (Which got some reason is always slow for me)

[Nigusu-Allehu]

Will this do all that Nuget.exe list does? (Which got some reason is always slow for me)

Yes, it will, but there is some difference. The equivalent command would be dotnet package search --source <My source>, a search with no search term. This would list packages in My source, similar to nuget.exe list. However, it will only list the first 20 packages. This number can be changed by using the --skip and --take optons. For example, dotnet package search --source <My source> --take 1000 would list the first 1000. nuget.exe list on the other hand constantly contacts a source and output the packages in it.

About the speed, I will have to do some testing and compare the two to make a conclusion.

[danmoseley]

@Nigusu-Allehu thanks

About the speed, I will have to do some testing and compare the two to make a conclusion.

The key here may be searching all the sources in parallel. I'm guessing that "restore" does not do this, because there is an ordering of feeds. But for listing, we want results from all the feeds.

[WeihanLi]

Maybe could be sealed

Suggested change

	internal class PackageSearchCommand : CommandBase
	internal sealed class PackageSearchCommand : CommandBase

[marcpopMSFT]

I don't see any tests for the new functionality.

[JonDouglas]

this looks great! amazing job.

there are a couple of thoughts I have about aliasing but they dont necessarily need to be addressed here.

dotnet search package <> dotnet package search <> dotnet search even.

@baronfel thoughts on above? Maybe in the far future we can refactor a completely 3-in-1 dotnet search experience where tools/workloads/packages all search nicely!

[baronfel]

I'm kinda sad that we have dotnet package search given that previous commands for interacting with packages are verb-forward instead of noun-forward. This is already a large source of user confusion, and I don't expect this to help :(

If we now have a package root noun, I'd really like to consider adding list and add subcommands to it and beginning the process of deprecating the old commands as part of .NET 9.

Having said that, awesome to have native package search in the CLI :D 🎆

[JonDouglas]

@baronfel Yes, a bit sad but at the same time these are challenges to work through. The prior art may have inspired the names too much i.e. workloads/tool, and hopefully a quick alias can fix that and even lead to some delight of users who are dyslexic like me accidentally using this command! Otherwise if this is a major concern by SDK, we should refactor and then alias anyway given it could be helpful.

[WeihanLi]

Maybe could be static since there're no instance members

Suggested change

	internal class PackageCommandParser
	internal static class PackageCommandParser

[kartheekp-ms]

sdk/src/Cli/dotnet/commands/dotnet-restore/RestoreCommandParser.cs

Line 60 in 250dfb2

var command = new DocumentedCommand("restore", DocsLink, LocalizableStrings.AppFullName);

RestoreCommandParser passes additional argument (LocalizableStrings.AppFullName). I am not sure on what is the behavior change because of passing the additional parameter.

[Nigusu-Allehu]

/backport to release/8.0.2xx

[github-actions]

Started backporting to release/8.0.2xx: https://github.com/dotnet/sdk/actions/runs/7482205215

[github-actions]

@Nigusu-Allehu an error occurred while backporting to release/8.0.2xx, please check the run log for details!

Error: @Nigusu-Allehu is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=Nigusu-Allehu

[marcpopMSFT]

/backport to release/8.0.2xx

[github-actions]

Started backporting to release/8.0.2xx: https://github.com/dotnet/sdk/actions/runs/7482215172