dotnet tool run and install roll-forward option

[JL03-Yue]

! This pr does not contains the detection of compatible runtimes as it is still being discussed

dotnet tool run and install --roll-forward option

dotnet tool run --allow-roll-forward option

For dotnet tool run command, a --allow-roll-forward Option to parse the --allow-roll-forward option anywhere in the command using System.CommandLine is included, and it feed the value of this option (if any) into the actual Process.Start calls to launch tools (e.g. in the ToolRunCommand. Note that the --allow-roll-forward parsed is always inserted into the 'final' dotnet command first for positional argument purposes.

Use case
When the user has the local tool sample installed, and they invoke is using dotnet tool run sample --allow-roll-forward LatestMajor. This code rewrites that into dotnet --roll-forward Major <path to sampleEntryPoint.dll in the tool storage location>.

dotnet tool install --allow-roll-forward option for global tools

For dotnet tool install command for global tools, a --allow-roll-forward option to parse the --allow-roll-forward option anywhere in the dotnet tool install command for global tools is included. It updates the runtime config file for the tool to include a rollForward property set to Major according to the documentation of roll forward selection.

Use case
When the user is installing the global tool sample, and they install it using dotnet tool install sample -g --allow-roll-forward. This code will rewrite the runtimeConfig the for tool and set rollForward property to Major.

dotnet tool install --allow-roll-forward option for local tools

For dotnet tool install command for local tools, a --allow-roll-forward option to parse the --allow-roll-forward option anywhere in the dotnet tool install command for local tools is included. It stores the rollForward state in the local tool manifest file using the Add function in ToolManifestEditor, and read from the ToolManifestPackage using ToolManifestFinder. The rollForward is set to Major according to the documentation of roll forward selection.

Note that for tools in the same directory with same tool command, it returns the tool that has been added first. For tools installed then later installed with the --allow-roll-forward option. It updates the manifest to change the rollForward property to True. Note that to run the tool with dotnet [toolname], the rollForward does not work.

Use case
When the user is installing the local tool sample, and they install it using dotnet tool install sample --allow-roll-forward. This code will store the state in the manifest file and read from manifest file when running dotnet tool run [sampleToolCommand]

[KalleOlaviNiemitalo]

Seems related to #26824 but that one is for all runtime-options, not just --roll-forward.

[KalleOlaviNiemitalo]

How about dotnet tool run foo -- --roll-forward major; I think that should not treat --roll-forward as a dotnet option and should instead pass it to the tool only. But I didn't find a test for this case.

[JL03-Yue]

Seems related to #26824 but that one is for all runtime-options, not just --roll-forward.

Yes, it is a similar solution. The other issue discussion is at #30336.

[baronfel]

How about dotnet tool run foo -- --roll-forward major; I think that should not treat --roll-forward as a dotnet option and should instead pass it to the tool only. But I didn't find a test for this case.

This is a good thing to verify - -- should signal that everything afterwards is forwarded to the called tool.

[KalleOlaviNiemitalo]

I'd want to use Major roll-forward rather than LatestMajor, to minimize the risk that installing a later version of .NET Runtime breaks some tool that previously worked via roll-forward. RollForwardOptionDescription in install/LocalizableStrings.resx looks like --roll-forward=Major should work; but ToolInstallCommandParser.RollForwardOption is defined as a CliOption<bool>, and ToolPackageDownloader.UpdateRuntimeConfigFile can only set "LatestMajor".

[JL03-Yue]

Some more tests to be covered

[baronfel]

Thank you for the detailed description and coverage of the various scenarios! I'm excited for this first step along the road of making tools easier to use.