Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of Aspire service #41319

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Add implementation of Aspire service #41319

merged 2 commits into from
Jun 5, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented May 31, 2024

Adds Aspire.Tools.Service source package that contains code shared between WebTools (VS/VSCode) and dotnet-watch.

TODO: will follow up with moving some tests

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels May 31, 2024
@tmat tmat marked this pull request as ready for review May 31, 2024 22:33
@tmat tmat requested review from arunchndr and a team as code owners May 31, 2024 22:33
@tmat
Copy link
Member Author

tmat commented May 31, 2024

@BillHiebert
Copy link
Contributor

Should the namespace change? Specifically, the WebTools part.

@tmat
Copy link
Member Author

tmat commented Jun 3, 2024

@BillHiebert Doesn't matter too much since all the types are internal, but if you want it to change, we can change it.

Microsoft.Aspire?

We have Microsoft.AspNetCore.Watch.BrowserRefresh namespace for browser refresh component, dotnet-watch uses Microsoft.DotNet.Watcher.

I suggest we keep it as is for now and once we consume the shared package from WebTools repo we can change the namespace.

@tmat tmat merged commit 24855ca into dotnet:main Jun 5, 2024
36 checks passed
@tmat tmat deleted the AspireServer branch June 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Area-Watch untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants