-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify a version of cmake in global.json #41476
Conversation
`latest` is not supported by Arcade, and there's no `latest` archive in the Azure blob store, so force the most recent supported value here. ``` CommonLibrary\DownloadAndExtract : Download failed from https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/cmake/cmake-latest-win64-x64.zip At C:\d\source-indexer\bin\repo\sdk\eng\common\native\install-tool.ps1:90 char:22 ```
Winforms has the same dotnet/winforms#11490 |
Adding some folks for review so they are aware of this dependency and it's need to update. Looks like @joeloff added in dotnet/installer@3c87114#diff-8df3cd354bc584349d04ad5675b33c042d8b99b741b8b95af394c55e0f5001bfR11 |
Arcade docs said it should work Modify your global.json's native-tools section to change the version of your tools to one of the following values: I'm fine with going back to a specific version, but shouldn't this have failed previously? @directhex was there a change in Arcade to stop supporting it? It definitely used to work before. I don't see how this is failing everywhere all at once unless some other change was made to the blob storage. Has anyone pinged eng/FR to confirm? |
@@ -14,7 +14,7 @@ | |||
} | |||
}, | |||
"native-tools": { | |||
"cmake": "latest" | |||
"cmake": "3.21.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI there's a PR to bump to 3.26 in runtime: dotnet/runtime#103088
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not via global.json by the look of it. There's no valid cmake-3.26.0-win64-x64.zip
in the blob store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we don't use global.json for native tools
Dunno what to say. Maybe there's multiple bits of tooling which parse global.json and install cmake from it - the PowerShell stuff in eng/common/native definitely doesn't support The list I was given for the contents of the file store is:
|
I think a switch may have been dropped in the repo merge. It looks like the installer repo was using |
latest
is not supported by Arcade, and there's nolatest
archive in the Azure blob store, so force the most recent supported value here.