Fix userlocal #41735

Forgind · 2024-06-21T19:44:25Z

This attempts to find everywhere that we currently assume not-userlocal (where it's supported) and changes it to respect userlocal if specified.

As far as testing, I tried to do dotnet workload update with an SDK without this update, and it broke. I then tried it with these changes, and it succeeded.

I'm not very knowledgeable about what scenarios I should target. I'll keep testing things I can think of, but do either of you have a suggestion on where to focus my testing energy @baronfel @tmds?

baronfel · 2024-06-21T20:12:21Z

It looks like the two changes are in the main dotnet.dll and the resolver dll, right? So it could be a viable test to

get an Ubuntu or Red Hat WSL instance
install an 8.x sdk from distro sources
drop newly-built patched dlls onto that install
test workload install/update?

baronfel · 2024-06-21T20:13:56Z

Conceptually, it worries me how many distinct places you had to touch to fix this. It feels like we need some abstraction/mediator that we can ask for what this path should be to ensure that no code has the wrong idea.

Forgind · 2024-06-21T21:45:45Z

Conceptually, it worries me how many distinct places you had to touch to fix this. It feels like we need some abstraction/mediator that we can ask for what this path should be to ensure that no code has the wrong idea.

I think this is an excellent point. What makes this hard is that all the load-bearing changes are pretty clearly in one of three buckets: related to the install state, related to workload sets, or related to garbage collection, and for the first two cases, at least, even if something perfect existed, I wouldn't have known to reference it. There are a few rare cases in which we really do want the not-userlocal dotnet path regardless, notably as a fallback path in the resolver, so we can't just fully replace dotnetPath with dotnetOrUserLocalPath...

kasperk81 · 2024-06-22T07:36:47Z

It feels like we need some abstraction/mediator that we can ask for what this path should be to ensure that no code has the wrong idea.

simplification idea: remove dotnetPath argument from WorkloadInfoHelper and directly call CliFolderPathCalculatorCore.GetDotnetHomePath() for !IsUserLocal when initializing WorkloadInfoHelper.DotnetPath. it is still going through a wrapper but less fragmented in comparison.

marcpopMSFT · 2024-06-25T20:49:52Z

Hold for the workload set PR but this looks good otherwise

dsplaisted

Looks good. I think we'll need some sort of user-local test coverage to be confident that it works and doesn't regress when we make changes.

There are conflicts with the refactoring PR that need to be resolved.

dsplaisted · 2024-07-02T17:23:08Z

src/Cli/dotnet/commands/InstallingWorkloadCommand.cs

@@ -86,6 +87,7 @@ internal abstract class InstallingWorkloadCommand : WorkloadCommandBase
            _userProfileDir = creationResult.UserProfileDir;
            _sdkVersion = creationResult.SdkVersion;
            _sdkFeatureBand = new SdkFeatureBand(creationResult.SdkVersion);
+            _workloadRootDir = WorkloadFileBasedInstall.IsUserLocal(_dotnetPath, _sdkFeatureBand.ToString()) ? _userProfileDir : _dotnetPath;


Looking at the implementation of WorkloadFileBasedInstall.IsUserLocal, it has its own logic to calculate the feature band (in GetUserInstallFilePath). We should get rid of that and use SdkFeatureBand instead to keep everything consistent.

dsplaisted · 2024-07-02T17:31:54Z

src/Cli/dotnet/commands/dotnet-workload/WorkloadInfoHelper.cs

            ReleaseVersion currentSdkReleaseVersion = new(currentSdkVersion ?? Product.Version);
            _currentSdkFeatureBand = new SdkFeatureBand(currentSdkReleaseVersion);

            _targetSdkVersion = targetSdkVersion;
            userProfileDir ??= CliFolderPathCalculator.DotnetUserProfileFolderPath;
+            DotnetPath = dotnetDir ?? (WorkloadFileBasedInstall.IsUserLocal(Path.GetDirectoryName(Environment.ProcessPath), _currentSdkFeatureBand.ToString()) ?


Rather than setting the DotnetPath to the user local workload folder, I think we should have a separate property for the workload root. In some contexts we still want the actual dotnet root folder, for example when creating the SdkDirectoryWorkloadManifestProvider and workload resolver. These constructors have separate arguments to specify the user profile directory.

dsplaisted · 2024-07-02T17:34:56Z

src/Cli/dotnet/commands/dotnet-workload/update/WorkloadUpdateCommand.cs

@@ -110,7 +110,7 @@ public override int Execute()
                            {
                                return;
                            }
-                            UpdateWorkloads(false, manifestUpdates, offlineCache, context);
+                            UpdateWorkloadsWithInstallRecord(_sdkFeatureBand, manifestUpdates, false, context, offlineCache);


I think this method doesn't exist after the refactoring, so you'll have to go back and deal with the conflicts.

Forgind · 2024-07-15T18:13:00Z

What I did to test this version:

Created userlocal file at the correct location
Tried dotnet workload update --> failed because I had an install state referencing a nonexistent workload set in my user directory (good)
Deleted that install state
dotnet workload update --> succeeded
dotnet workload list (none installed)
dotnet workload install wasm-tools --> Workload ID wasm-tools is not recognized (?)
dotnet workload search (found test workloads)
dotnet workload install microsoft-net-sdk-testworkload (succeeded)
dotnet workload list (correct)
dotnet workload update (succeeded)

dsplaisted

Looks good. Make sure to look at and hopefully address the comments from this review and the previous one (from before the rebase).

dsplaisted · 2024-07-17T05:25:32Z

src/Cli/dotnet/commands/dotnet-workload/WorkloadInfoHelper.cs

@@ -61,6 +61,8 @@ internal class WorkloadInfoHelper : IWorkloadInfoHelper
                shouldLog: false);

            WorkloadRecordRepo = workloadRecordRepo ?? Installer.GetWorkloadInstallationRecordRepository();
+
+            DotnetPath = dotnetDir ?? (WorkloadFileBasedInstall.IsUserLocal(DotnetPath, _currentSdkFeatureBand.ToString()) ? userProfileDir : DotnetPath);


Re-commenting since my previous comment lost its home in the rebase:

Rather than setting the DotnetPath to the user local workload folder, I think we should have a separate property for the workload root. In some contexts we still want the actual dotnet root folder, for example when creating the SdkDirectoryWorkloadManifestProvider and workload resolver. These constructors have separate arguments to specify the user profile directory.

I'll throw out that we don't currently use this in any context in which we'd want the real dotnet root folder, but I can make the change anyway to avoid confusion down the line.

dsplaisted · 2024-07-17T05:26:59Z

src/Cli/dotnet/commands/dotnet-workload/install/FileBasedInstaller.cs


            var newModeString = newMode == null ? "<null>" : (newMode.Value ? WorkloadConfigCommandParser.UpdateMode_WorkloadSet : WorkloadConfigCommandParser.UpdateMode_Manifests);
            _reporter.WriteLine(string.Format(LocalizableStrings.UpdatedWorkloadMode, newModeString));
        }

+        private void UpdateInstallState(SdkFeatureBand sdkFeatureBand, Action<InstallStateContents> update)


Nice refactoring. 👍

dsplaisted · 2024-07-17T06:04:05Z

src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs

            _sdkVersionBand = new SdkFeatureBand(sdkVersion);
            _workloadSetVersionFromConstructor = workloadSetVersion;
            _globalJsonPathFromConstructor = globalJsonPath;

-            var knownManifestIdsFilePath = Path.Combine(_sdkRootPath, "sdk", sdkVersion, "KnownWorkloadManifests.txt");
+            string? userManifestsRoot = userProfileDir is null ? null : Path.Combine(userProfileDir, "sdk-manifests");
+            string dotnetManifestRoot = Path.Combine(_sdkOrUserLocalPath, "sdk-manifests");


If I'm following the code correctly, at this point there is no difference between _sdkRootPath and _sdkOrUserLocalPath, and _sdkOrUserLocalPath may change later. So I think it would be clearer to use the value that doesn't change:

Suggested change

string dotnetManifestRoot = Path.Combine(_sdkOrUserLocalPath, "sdk-manifests");

string dotnetManifestRoot = Path.Combine(_sdkRootPath, "sdk-manifests");

It might also be clearer to move the initialization of _sdkOrUserLocalPath closer to where it may be set to the user local path, or to set it to null initially and then set it to _sdkRootPath after the following if statement.

dsplaisted · 2024-07-17T06:05:31Z

src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/SdkDirectoryWorkloadManifestProvider.cs

+            var knownManifestIdsFilePath = Path.Combine(_sdkOrUserLocalPath, "sdk", sdkVersion, "KnownWorkloadManifests.txt");
            if (!File.Exists(knownManifestIdsFilePath))
            {
-                knownManifestIdsFilePath = Path.Combine(_sdkRootPath, "sdk", sdkVersion, "IncludedWorkloadManifests.txt");
+                knownManifestIdsFilePath = Path.Combine(_sdkOrUserLocalPath, "sdk", sdkVersion, "IncludedWorkloadManifests.txt");


I think that KnownWorkloadManifests.txt and IncludedWorkloadManifests.txt are files that are part of the SDK installation, and would not be expected to be in the user local path. So I think we should probably still use _sdkRootPath when constructing these paths. Does that make sense?

I didn't know anything about them, so I thought they might be writable, in which case they should be in the user local folder, but if they don't go there, I can move it back to _sdkRootPath.

l3m · 2024-08-02T14:04:46Z

This is a blocker for us. We use nix flakes on macOS, as devs can just run nix develop and start coding. As our devs often come from a Windows or Linux background, this allows them to efficiently work on iOS apps without having to follow complex guides to set up their dev system. This is especially helpful when working on different projects in various stacks and with specific requirements/dependencies.

In addition, it seems harmful from a security perspective to require root permissions just to install workloads. userlocal nicely solves this problem.

It would be great if this fix is backported into the next Net8 SDK release.

baronfel · 2024-08-02T14:30:33Z

Some additional context - Nix can be used a package manager on Linux and macOS, and in either case uses our tarball releases to drive the installation: https://github.com/NixOS/nixpkgs/blob/cf05eeada35e122770c5c14add958790fcfcbef5/pkgs/development/compilers/dotnet/versions/8.0.nix#L156

anpin · 2024-08-28T12:26:15Z

this is still failing on nixos with dotnet-sdk 9.0.100-preview.7.24407.12

reproduction repository is still here

> dotnet --info
.NET SDK:
 Version:           9.0.100-preview.7.24407.12
 Commit:            d672b8a045
 Workload version:  9.0.100-manifests.ad7d8b9c
 MSBuild version:   17.12.0-preview-24374-02+48e81c6f1

Runtime Environment:
 OS Name:     nixos
 OS Version:  24.11
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /nix/store/k3pwldrpihar4j8d4i7c464nzdczbk5b-dotnet-sdk-9.0.100-preview.7.24407.12/sdk/9.0.100-preview.7.24407.12/

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
 [maui-android]
   Installation Source: SDK 9.0.100-preview.7
   Manifest Version:    9.0.0-preview.7.24407.4/9.0.100-preview.7
   Manifest Path:       /home/a/.dotnet/sdk-manifests/9.0.100-preview.7/microsoft.net.sdk.maui/9.0.0-preview.7.24407.4/WorkloadManifest.json
   Install Type:        FileBased


Host:
  Version:      9.0.0-preview.7.24405.7
  Architecture: x64
  Commit:       static

.NET SDKs installed:
  9.0.100-preview.7.24407.12 [/nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 9.0.0-preview.7.24406.2 [/nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 9.0.0-preview.7.24405.7 [/nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

> ls -al /nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined/metadata/workloads/9.0.100/userlocal
.r--r--r-- 0 root 31 Dec  1969 /nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined/metadata/workloads/9.0.100/userlocal

> dotnet workload update
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Skipping NuGet package signature verification.
Updated advertising manifest microsoft.net.sdk.tvos.
Updated advertising manifest microsoft.net.workload.mono.toolchain.net6.
Updated advertising manifest microsoft.net.workload.mono.toolchain.net7.
Updated advertising manifest microsoft.net.sdk.android.
Updated advertising manifest microsoft.net.workload.mono.toolchain.current.
Updated advertising manifest microsoft.net.workload.emscripten.current.
Updated advertising manifest microsoft.net.workload.emscripten.net8.
Updated advertising manifest microsoft.net.workload.emscripten.net6.
Updated advertising manifest microsoft.net.workload.emscripten.net7.
Updated advertising manifest microsoft.net.sdk.aspire.
Updated advertising manifest microsoft.net.sdk.macos.
Updated advertising manifest microsoft.net.sdk.maccatalyst.
Updated advertising manifest microsoft.net.sdk.maui.
Updated advertising manifest microsoft.net.sdk.ios.
Updated advertising manifest microsoft.net.workload.mono.toolchain.net8.
Installing workload manifest microsoft.net.sdk.aspire version 8.1.0...
Workload installation failed. Rolling back installed packs...
Workload update failed: Read-only file system : '/nix/store/iciqfvy2ppdyxiz7n1lxkns04k7m5294-dotnet-core-combined/metadata/workloads/X64'

> dotnet workload list

Installed Workload Id      Manifest Version                               Installation Source
-----------------------------------------------------------------------------------------------
maui-android               9.0.0-preview.7.24407.4/9.0.100-preview.7      SDK 9.0.100-preview.7

Use `dotnet workload search` to find additional workloads to install.

> dotnet restore
  Determining projects to restore...
/nix/store/k3pwldrpihar4j8d4i7c464nzdczbk5b-dotnet-sdk-9.0.100-preview.7.24407.12/sdk/9.0.100-preview.7.24407.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: maui-android [/home/a/projects/maui-on-nix/src/MauiOnNix.csproj::TargetFramework=net8.0-android]
/nix/store/k3pwldrpihar4j8d4i7c464nzdczbk5b-dotnet-sdk-9.0.100-preview.7.24407.12/sdk/9.0.100-preview.7.24407.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/home/a/projects/maui-on-nix/src/MauiOnNix.csproj::TargetFramework=net8.0-android]

kasperk81 · 2024-08-28T13:17:21Z

because it was not included in p7. it was included in rc1.

anpin · 2024-10-11T01:50:16Z

> dotnet --info
.NET SDK:
 Version:           9.0.100-rc.1.24452.12
 Commit:            81a714c6d3
 Workload version:  9.0.100-manifests.2acaa684
 MSBuild version:   17.12.0-preview-24422-09+d17ec720d

Runtime Environment:
 OS Name:     nixos
 OS Version:  24.11
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /nix/store/xrbswlskla2qi3hqf2j2543k1qwq10l0-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
 [maui-android]
   Installation Source: SDK 9.0.100-rc.1
   Manifest Version:    9.0.0-rc.1.24453.9/9.0.100-rc.1
   Manifest Path:       /home/a/.dotnet/sdk-manifests/9.0.100-rc.1/microsoft.net.sdk.maui/9.0.0-rc.1.24453.9/WorkloadManifest.json
   Install Type:        FileBased


Host:
  Version:      9.0.0-rc.1.24431.7
  Architecture: x64
  Commit:       static

.NET SDKs installed:
  9.0.100-rc.1.24452.12 [/nix/store/s8b9hyrb5gdsam9nay59nxcz7k4jb2aj-dotnet-core-combined/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 9.0.0-rc.1.24452.1 [/nix/store/s8b9hyrb5gdsam9nay59nxcz7k4jb2aj-dotnet-core-combined/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 9.0.0-rc.1.24431.7 [/nix/store/s8b9hyrb5gdsam9nay59nxcz7k4jb2aj-dotnet-core-combined/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/nix/store/s8b9hyrb5gdsam9nay59nxcz7k4jb2aj-dotnet-core-combined]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download
> dotnet workload restore
Installing workloads: maui-android

Skipping NuGet package signature verification.
Installing workload manifest microsoft.net.sdk.aspire version 8.2.1...
Workload(s) 'maui-android' are already installed.
Installing pack Microsoft.AspNetCore.Components.WebView.Maui version 9.0.0-rc.1.24453.9...
Pack Microsoft.AspNetCore.Components.WebView.Maui version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.AspNetCore.Components.WebView.Maui version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Sdk version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Sdk version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Sdk version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Sdk version 8.0.82...
Pack Microsoft.Maui.Sdk version 8.0.82 is already installed.
Writing workload pack installation record for Microsoft.Maui.Sdk version 8.0.82...
Installing pack Microsoft.Maui.Graphics version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Graphics version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Graphics version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Resizetizer version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Resizetizer version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Resizetizer version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Templates.net9 version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Templates.net9 version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Templates.net9 version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Templates.net8 version 8.0.82...
Pack Microsoft.Maui.Templates.net8 version 8.0.82 is already installed.
Writing workload pack installation record for Microsoft.Maui.Templates.net8 version 8.0.82...
Installing pack Microsoft.Maui.Core version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Core version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Core version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Controls version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Controls version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Controls version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Controls.Build.Tasks version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Controls.Build.Tasks version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Controls.Build.Tasks version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Controls.Core version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Controls.Core version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Controls.Core version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Controls.Xaml version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Controls.Xaml version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Controls.Xaml version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Controls.Compatibility version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Controls.Compatibility version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Controls.Compatibility version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Maui.Essentials version 9.0.0-rc.1.24453.9...
Pack Microsoft.Maui.Essentials version 9.0.0-rc.1.24453.9 is already installed.
Writing workload pack installation record for Microsoft.Maui.Essentials version 9.0.0-rc.1.24453.9...
Installing pack Microsoft.Android.Sdk.Linux version 35.0.0-rc.1.80...
Pack Microsoft.Android.Sdk.Linux version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Sdk.Linux version 35.0.0-rc.1.80...
Installing pack Microsoft.Android.Sdk.Linux version 34.0.138...
Pack Microsoft.Android.Sdk.Linux version 34.0.138 is already installed.
Writing workload pack installation record for Microsoft.Android.Sdk.Linux version 34.0.138...
Installing pack Microsoft.Android.Ref.35 version 35.0.0-rc.1.80...
Pack Microsoft.Android.Ref.35 version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Ref.35 version 35.0.0-rc.1.80...
Installing pack Microsoft.Android.Runtime.35.android-arm version 35.0.0-rc.1.80...
Pack Microsoft.Android.Runtime.35.android-arm version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Runtime.35.android-arm version 35.0.0-rc.1.80...
Installing pack Microsoft.Android.Runtime.35.android-arm64 version 35.0.0-rc.1.80...
Pack Microsoft.Android.Runtime.35.android-arm64 version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Runtime.35.android-arm64 version 35.0.0-rc.1.80...
Installing pack Microsoft.Android.Runtime.35.android-x86 version 35.0.0-rc.1.80...
Pack Microsoft.Android.Runtime.35.android-x86 version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Runtime.35.android-x86 version 35.0.0-rc.1.80...
Installing pack Microsoft.Android.Runtime.35.android-x64 version 35.0.0-rc.1.80...
Pack Microsoft.Android.Runtime.35.android-x64 version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Runtime.35.android-x64 version 35.0.0-rc.1.80...
Installing pack Microsoft.Android.Templates version 35.0.0-rc.1.80...
Pack Microsoft.Android.Templates version 35.0.0-rc.1.80 is already installed.
Writing workload pack installation record for Microsoft.Android.Templates version 35.0.0-rc.1.80...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-arm version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.Mono.android-arm version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-arm version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-arm64 version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.Mono.android-arm64 version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-arm64 version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-x64 version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.Mono.android-x64 version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-x64 version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-x86 version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.Mono.android-x86 version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-x86 version 8.0.8...
Installing pack Microsoft.NET.Runtime.MonoAOTCompiler.Task version 8.0.8...
Pack Microsoft.NET.Runtime.MonoAOTCompiler.Task version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NET.Runtime.MonoAOTCompiler.Task version 8.0.8...
Installing pack Microsoft.NET.Runtime.MonoTargets.Sdk version 8.0.8...
Pack Microsoft.NET.Runtime.MonoTargets.Sdk version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NET.Runtime.MonoTargets.Sdk version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86 version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86 version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86 version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64 version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64 version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64 version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64 version 8.0.8...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64 version 8.0.8 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64 version 8.0.8...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-arm version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.Mono.android-arm version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-arm version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-arm64 version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.Mono.android-arm64 version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-arm64 version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-x64 version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.Mono.android-x64 version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-x64 version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.Mono.android-x86 version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.Mono.android-x86 version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.Mono.android-x86 version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NET.Runtime.MonoAOTCompiler.Task version 9.0.0-rc.1.24431.7...
Pack Microsoft.NET.Runtime.MonoAOTCompiler.Task version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NET.Runtime.MonoAOTCompiler.Task version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NET.Runtime.MonoTargets.Sdk version 9.0.0-rc.1.24431.7...
Pack Microsoft.NET.Runtime.MonoTargets.Sdk version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NET.Runtime.MonoTargets.Sdk version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86 version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86 version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86 version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64 version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64 version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64 version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm version 9.0.0-rc.1.24431.7...
Installing pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64 version 9.0.0-rc.1.24431.7...
Pack Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64 version 9.0.0-rc.1.24431.7 is already installed.
Writing workload pack installation record for Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64 version 9.0.0-rc.1.24431.7...
Garbage collecting for SDK feature band(s) 9.0.100-rc.1...
Uninstalling workload manifest microsoft.net.sdk.aspire version 8.2.1/8.0.100...

Successfully installed workload(s) .
> dotnet build
  Determining projects to restore...
/nix/store/xrbswlskla2qi3hqf2j2543k1qwq10l0-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: maui-android [/home/a/projects/maui-on-nix/src/MauiOnNix.csproj::TargetFramework=net8.0-android]
/nix/store/xrbswlskla2qi3hqf2j2543k1qwq10l0-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/home/a/projects/maui-on-nix/src/MauiOnNix.csproj::TargetFramework=net8.0-android]

Build FAILED.

/nix/store/xrbswlskla2qi3hqf2j2543k1qwq10l0-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: maui-android [/home/a/projects/maui-on-nix/src/MauiOnNix.csproj::TargetFramework=net8.0-android]
/nix/store/xrbswlskla2qi3hqf2j2543k1qwq10l0-dotnet-sdk-9.0.100-rc.1.24452.12/sdk/9.0.100-rc.1.24452.12/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/home/a/projects/maui-on-nix/src/MauiOnNix.csproj::TargetFramework=net8.0-android]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.41

dotnet-issue-labeler bot added Area-Workloads untriaged labels Jun 21, 2024

dsplaisted reviewed Jul 2, 2024

View reviewed changes

Forgind force-pushed the userlocal-fix branch from 66c2304 to c7cf5d0 Compare July 15, 2024 18:09

Forgind force-pushed the userlocal-fix branch from 72c3672 to 1040713 Compare July 15, 2024 23:34

dsplaisted approved these changes Jul 17, 2024

View reviewed changes

Forgind changed the base branch from release/8.0.4xx to main July 18, 2024 13:34

Forgind added 4 commits July 18, 2024 09:34

Reimplement userlocal

Verified

This commit was signed with the committer’s verified signature.

joboet Jonas Böttiger

GPG key ID: 704E0149B0194B3C

Verified
Learn about vigilant mode

7069203

Fix NRE

Verified

This commit was signed with the committer’s verified signature.

joboet Jonas Böttiger

GPG key ID: 704E0149B0194B3C

Verified
Learn about vigilant mode

8010ef2

Feedback

Verified

This commit was signed with the committer’s verified signature.

joboet Jonas Böttiger

GPG key ID: 704E0149B0194B3C

Verified
Learn about vigilant mode

6318b99

Tweak test

Loading
Loading status checks…

5e929bb

Forgind force-pushed the userlocal-fix branch from 2e0e7f6 to 5e929bb Compare July 18, 2024 13:35

marcpopMSFT merged commit 9265990 into dotnet:main Jul 23, 2024
37 checks passed

This was referenced Oct 11, 2024

dotnet workload install in userlocal mode fails with source-build .NET 9 Preview 5 #41726

Closed

[BUG] 'To build this project, the following workloads must be installed: maui-android', but the workload is already installed #37706

Closed

marcpopMSFT mentioned this pull request Oct 14, 2024

Customer using userlocal maui install unable to find maui workloads #44165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix userlocal #41735

Fix userlocal #41735

Forgind commented Jun 21, 2024 •

edited

Loading

baronfel commented Jun 21, 2024

baronfel commented Jun 21, 2024

Forgind commented Jun 21, 2024

kasperk81 commented Jun 22, 2024

marcpopMSFT commented Jun 25, 2024

dsplaisted left a comment

dsplaisted Jul 2, 2024

dsplaisted Jul 2, 2024

dsplaisted Jul 2, 2024

Forgind commented Jul 15, 2024

dsplaisted left a comment

dsplaisted Jul 17, 2024

Forgind Jul 18, 2024

dsplaisted Jul 17, 2024

dsplaisted Jul 17, 2024

dsplaisted Jul 17, 2024

Forgind Jul 18, 2024

l3m commented Aug 2, 2024 •

edited

Loading

baronfel commented Aug 2, 2024

anpin commented Aug 28, 2024 •

edited

Loading

kasperk81 commented Aug 28, 2024

anpin commented Oct 11, 2024

	string dotnetManifestRoot = Path.Combine(_sdkOrUserLocalPath, "sdk-manifests");
	string dotnetManifestRoot = Path.Combine(_sdkRootPath, "sdk-manifests");

Fix userlocal #41735

Fix userlocal #41735

Conversation

Forgind commented Jun 21, 2024 • edited Loading

baronfel commented Jun 21, 2024

baronfel commented Jun 21, 2024

Forgind commented Jun 21, 2024

kasperk81 commented Jun 22, 2024

marcpopMSFT commented Jun 25, 2024

dsplaisted left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Forgind commented Jul 15, 2024

dsplaisted left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l3m commented Aug 2, 2024 • edited Loading

baronfel commented Aug 2, 2024

anpin commented Aug 28, 2024 • edited Loading

kasperk81 commented Aug 28, 2024

anpin commented Oct 11, 2024

Forgind commented Jun 21, 2024 •

edited

Loading

l3m commented Aug 2, 2024 •

edited

Loading

anpin commented Aug 28, 2024 •

edited

Loading