-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Windows.UI.Xaml profile for Windows SDK projections #41936
Enable Windows.UI.Xaml profile for Windows SDK projections #41936
Conversation
9920f61
to
3059090
Compare
e3c75d9
to
d9a21c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good.
It does differ from how we normally handle profiles. Normally profiles are always a subset of the full set of references for a shared framework, and a reference without a profile would be used to reference all of the references. In that model, instead of Microsoft.Windows.SDK.NET.Ref.Full
, you'd just have Microsoft.Windows.SDK.NET.Ref
(the same as you have today). Then you'd add Microsoft.Windows.SDK.NET.Ref.Windows
for the subset without Windows.UI.Xaml.
I'm not sure if there's going to be anything wrong with the way this PR currently implements things, but if there's no specific reason to use two separate profiles, it's probably safer to keep to the existing model.
I don't remember how exactly PrivateAssets="all"
behaves for FrameworkReferences. If it stops the framework reference from flowing across project references, then I think the transitive error check would never trigger. If it doesn't stop the FrameworkReference from flowing through NuGet packages, then in the current version of this PR you could have errors referencing NuGet packages which depend on the Microsoft.Windows.SDK.NET.Ref
framework, which doesn't exist anymore.
9b0f78e
to
fe84163
Compare
d1ae2cb
to
d28948a
Compare
f0d47eb
to
9ba50a9
Compare
9ba50a9
to
bbe8802
Compare
...sks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets
Outdated
Show resolved
Hide resolved
939027c
to
b81b8b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
src/Tasks/Microsoft.NET.Build.Tasks/ResolveRuntimePackAssets.cs
Outdated
Show resolved
Hide resolved
...sks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Windows.targets
Outdated
Show resolved
Hide resolved
eda9591
to
28ea4d4
Compare
src/Tasks/Microsoft.NET.Build.Tasks/ResolveRuntimePackAssets.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/ResolveRuntimePackAssets.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
f1034c6
to
6c72933
Compare
@Sergio0694 after updating a blank WinUI 3 .NET 8 app to <WindowsSdkPackageVersion>10.0.19041.48</WindowsSdkPackageVersion> I am now seeing both of these are now valid: var red = Microsoft.UI.Colors.Red;
var red2 = Windows.UI.Colors.Red; Is that change intentional 🤔 ? Same goes for |
This PR adds support for two new profiles for the Windows SDK projections (aka "Microsoft.Windows.SDK.NET.Ref"):
Additionally, it includes the following changes:
Note
Need to add tests, and we still need to publish the updated Windows SDK projections, but reviews welcome.